GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-101524: Only Use Public C-API in the _xxsubinterpreters Module by ericsnowcurrently · Pull Request #105258 · python/cpython

Conversation

@ericsnowcurrently

@ericsnowcurrently ericsnowcurrently commented Jun 2, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

The _xxsubinterpreters module was meant to only use public API. Some internal C-API usage snuck in over the last few years (e.g. gh-28969). This fixes that.

  • Issue: Maybe Drop "channels" from _xxsubinterpreters #101524

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
ericsnowcurrently added 4 commits June 2, 2023 16:20
@ericsnowcurrently
Revert "bpo-35081: Move interpreteridobject.h to Include/internal/ (p…
680df71 
…ythonGH-28969)"

This reverts commit 063abd9.
@ericsnowcurrently
Drop internal includes from _xxsubinterpreters.
452f99e
@ericsnowcurrently
Drop internal includes from _xxinterpchannels.
2ff0bed
@ericsnowcurrently
Do not build with the internal headers.
4c101ee
@ericsnowcurrently ericsnowcurrently added the skip news label Jun 2, 2023
@ericsnowcurrently
ericsnowcurrently requested a review from a team as a code owner June 2, 2023 22:28
@bedevere-bot bedevere-bot added the awaiting core review label Jun 2, 2023
@bedevere-bot bedevere-bot mentioned this pull request Jun 2, 2023
Maybe Drop "channels" from _xxsubinterpreters #101524
Closed
@ericsnowcurrently
ericsnowcurrently removed the request for review from a team June 2, 2023 22:28
@ericsnowcurrently
ericsnowcurrently enabled auto-merge (squash) June 2, 2023 22:30
@ericsnowcurrently
ericsnowcurrently merged commit e6373c0 into python:main Jun 2, 2023
@bedevere-bot bedevere-bot removed the awaiting core review label Jun 2, 2023
@ericsnowcurrently
ericsnowcurrently deleted the _xxsubinterpreters-public-api-only branch June 2, 2023 23:11
@ericsnowcurrently ericsnowcurrently added the needs backport to 3.12 only security fixes label Jul 26, 2023
@miss-islington

miss-islington commented Jul 26, 2023

Copy link
Copy Markdown
Contributor

Thanks @ericsnowcurrently for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot

bedevere-bot commented Jul 26, 2023

Copy link
Copy Markdown

GH-107303 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.12 only security fixes label Jul 26, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 26, 2023
@ericsnowcurrently @miss-islington
pythongh-101524: Only Use Public C-API in the _xxsubinterpreters Modu…
f1e88f8 
…le (pythongh-105258)

The _xxsubinterpreters module was meant to only use public API.  Some internal C-API usage snuck in over the last few years (e.g. pythongh-28969).  This fixes that.
(cherry picked from commit e6373c0)

Co-authored-by: Eric Snow <[email protected]>
ericsnowcurrently added a commit that referenced this pull request Jul 27, 2023
@miss-islington @ericsnowcurrently
[3.12] gh-101524: Only Use Public C-API in the _xxsubinterpreters Mod…
57ef065 
…ule (gh-105258) (gh-107303)

The _xxsubinterpreters module was meant to only use public API.  Some internal C-API usage snuck in over the last few years (e.g. gh-28969).  This fixes that.
(cherry picked from commit e6373c0)

Co-authored-by: Eric Snow <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@ericsnowcurrently @miss-islington @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.