GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — gh-107298: Docs: add targets for some :c:member: and :c:macro: references by serhiy-storchaka · Pull Request #107316 · python/cpython

Conversation

serhiy-storchaka commented Jul 26, 2023 •

edited by github-actions Bot

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Member

Add targets for PyStructSequence_Desc and PyStructSequence_Field members and macros like Py_EQ.
Fix target for Py_RETURN_RICHCOMPARE.

Issue: Fix Sphinx warnings in the C API documentation #107298

📚 Documentation preview 📚: https://cpython-previews--107316.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

serhiy-storchaka added docs

Documentation in the Doc dir

skip news topic-C-API needs backport to 3.11

only security fixes

needs backport to 3.12 only security fixes labels

Jul 26, 2023

serhiy-storchaka requested a review from vstinner

July 26, 2023 20:03

bedevere-bot added the awaiting core review label

Jul 26, 2023

bedevere-bot mentioned this pull request

Jul 26, 2023

Fix Sphinx warnings in the C API documentation #107298

Closed

serhiy-storchaka force-pushed the docs-capi-targets branch from e15b0f6 to 0e1f4a9 Compare

July 26, 2023 21:07


          pythongh-107298: Docs: add targets for some :c:member: and :c:macro: …

310bf2c

…references

Add targets for PyStructSequence_Desc and PyStructSequence_Field members
and macros like Py_EQ.
Fix target for Py_RETURN_RICHCOMPARE.

serhiy-storchaka force-pushed the docs-capi-targets branch from 0e1f4a9 to 310bf2c Compare

July 26, 2023 21:33

serhiy-storchaka mentioned this pull request

Jul 26, 2023

gh-107298: Fix Sphinx warnings in the C API doc #107302

Merged

vstinner approved these changes

Jul 26, 2023

View reviewed changes

vstinner left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. It would be even better with upper case (see my comment) :-)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

Comment thread

Doc/c-api/tuple.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot added awaiting merge and removed awaiting core review labels

Jul 26, 2023


          Update Doc/c-api/tuple.rst

7425d8d

Co-authored-by: Victor Stinner <[email protected]>

serhiy-storchaka commented

Jul 27, 2023

View reviewed changes

Comment thread

Doc/c-api/tuple.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Doc/c-api/tuple.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Doc/c-api/tuple.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Doc/c-api/tuple.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Doc/c-api/tuple.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Doc/c-api/tuple.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.


          Apply suggestions from code review

474224a

serhiy-storchaka merged commit abec9a1 into python:main

Jul 27, 2023

miss-islington commented Jul 27, 2023

Copy link

Copy Markdown

Contributor

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot removed the awaiting merge label

Jul 27, 2023

serhiy-storchaka deleted the docs-capi-targets branch

July 27, 2023 06:04

miss-islington commented Jul 27, 2023

Copy link

Copy Markdown

Contributor

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker abec9a1b20b70d8ced401d59fc4f02b331c6568b 3.11

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

miss-islington assigned serhiy-storchaka

Jul 27, 2023

bedevere-bot commented Jul 27, 2023

Copy link

Copy Markdown

GH-107332 is a backport of this pull request to the 3.12 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Jul 27, 2023


          pythongh-107298: Docs: add targets for some :c:member: and :c:macro: …

1cf1f25

…references (pythonGH-107316)

Add targets for PyStructSequence_Desc and PyStructSequence_Field members
and macros like Py_EQ.
Fix target for Py_RETURN_RICHCOMPARE.
(cherry picked from commit abec9a1)

Co-authored-by: Serhiy Storchaka <[email protected]>

bedevere-bot removed the needs backport to 3.12 only security fixes label

Jul 27, 2023

serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request

Jul 27, 2023


          [3.11] pythongh-107298: Docs: add targets for some :c:member: and :c:…

59cfa09

…macro: references (pythonGH-107316)

Add targets for PyStructSequence_Desc and PyStructSequence_Field members
and macros like Py_EQ.
Fix target for Py_RETURN_RICHCOMPARE..
(cherry picked from commit abec9a1)

Co-authored-by: Serhiy Storchaka <[email protected]>

bedevere-bot commented Jul 27, 2023

Copy link

Copy Markdown

GH-107333 is a backport of this pull request to the 3.11 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot removed the needs backport to 3.11 only security fixes label

Jul 27, 2023

serhiy-storchaka added a commit that referenced this pull request

Jul 27, 2023


          [3.11] gh-107298: Docs: add targets for some :c:member: and :c:macro:…

9513acf

… references (GH-107316) (GH-107333)

Add targets for PyStructSequence_Desc and PyStructSequence_Field members
and macros like Py_EQ.
Fix target for Py_RETURN_RICHCOMPARE.
(cherry picked from commit abec9a1)

serhiy-storchaka added a commit that referenced this pull request

Jul 27, 2023


          [3.12] gh-107298: Docs: add targets for some :c:member: and :c:macro:…

36e96ba

… references (GH-107316) (GH-107332)

Add targets for PyStructSequence_Desc and PyStructSequence_Field members
and macros like Py_EQ.
Fix target for Py_RETURN_RICHCOMPARE.
(cherry picked from commit abec9a1)

Co-authored-by: Serhiy Storchaka <[email protected]>

serhiy-storchaka removed their assignment

Sep 8, 2023

Reviewers

vstinner

vstinner approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs

Documentation in the Doc dir

skip news topic-C-API

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

serhiy-storchaka commented Jul 26, 2023 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vstinner left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

miss-islington commented Jul 27, 2023

Uh oh!

miss-islington commented Jul 27, 2023

Uh oh!

bedevere-bot commented Jul 27, 2023

Uh oh!

bedevere-bot commented Jul 27, 2023

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

serhiy-storchaka commented Jul 26, 2023 •

edited by github-actions Bot

Loading

Uh oh!

There was an error while loading. Please reload this page.