GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — gh-107298: Fix yet more Sphinx warnings in the C API doc by serhiy-storchaka · Pull Request #107345 · python/cpython

Conversation

serhiy-storchaka commented Jul 27, 2023 •

edited by github-actions Bot

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Member

Issue: Fix Sphinx warnings in the C API documentation #107298

📚 Documentation preview 📚: https://cpython-previews--107345.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

serhiy-storchaka added docs

Documentation in the Doc dir

topic-C-API needs backport to 3.11

only security fixes

needs backport to 3.12 only security fixes labels

Jul 27, 2023

serhiy-storchaka requested a review from vstinner

July 27, 2023 12:36

bedevere-bot mentioned this pull request

Jul 27, 2023

Fix Sphinx warnings in the C API documentation #107298

Closed

bedevere-bot added awaiting core review skip news labels

Jul 27, 2023


          pythongh-107298: Fix yet more Sphinx warnings in the C API doc

serhiy-storchaka force-pushed the docs-capi-warns branch from cbcd3a9 to 1858649 Compare

July 27, 2023 13:09


          Fix also Doc/extending/.

04873f3

vstinner approved these changes

Jul 27, 2023

View reviewed changes

vstinner left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Also, I like your PR title :-D

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

serhiy-storchaka reacted with laugh emoji

All reactions

😄 1 reaction

bedevere-bot added awaiting merge and removed awaiting core review labels

Jul 27, 2023

serhiy-storchaka force-pushed the docs-capi-warns branch from cd88579 to 04873f3 Compare

July 27, 2023 15:03

serhiy-storchaka merged commit 9833052 into python:main

Jul 27, 2023

miss-islington commented Jul 27, 2023

Copy link

Copy Markdown

Contributor

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot removed the awaiting merge label

Jul 27, 2023

miss-islington commented Jul 27, 2023

Copy link

Copy Markdown

Contributor

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 983305268e2291b0a7835621b81bf40cba7c27f3 3.12

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

serhiy-storchaka deleted the docs-capi-warns branch

July 27, 2023 15:44

miss-islington assigned serhiy-storchaka

Jul 27, 2023

miss-islington commented Jul 27, 2023

Copy link

Copy Markdown

Contributor

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 983305268e2291b0a7835621b81bf40cba7c27f3 3.11

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request

Jul 28, 2023


          [3.12] pythongh-107298: Fix yet more Sphinx warnings in the C API doc (…

47dcb53

…pythonGH-107345)

(cherry picked from commit 9833052)

Co-authored-by: Serhiy Storchaka <[email protected]>

bedevere-bot commented Jul 28, 2023

Copy link

Copy Markdown

GH-107380 is a backport of this pull request to the 3.12 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot removed the needs backport to 3.12 only security fixes label

Jul 28, 2023

serhiy-storchaka added a commit that referenced this pull request

Jul 28, 2023


          [3.12] gh-107298: Fix yet more Sphinx warnings in the C API doc (GH-1…

…07345) (GH-107380)

(cherry picked from commit 9833052)

serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request

Jul 28, 2023


          [3.11] pythongh-107298: Fix yet more Sphinx warnings in the C API doc (…

d9967a6

…pythonGH-107345).

(cherry picked from commit 9833052)

Co-authored-by: Serhiy Storchaka <[email protected]>

bedevere-bot commented Jul 28, 2023

Copy link

Copy Markdown

GH-107381 is a backport of this pull request to the 3.11 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot removed the needs backport to 3.11 only security fixes label

Jul 28, 2023

serhiy-storchaka added a commit that referenced this pull request

Jul 28, 2023


          [3.11] gh-107298: Fix yet more Sphinx warnings in the C API doc (GH-1…

d9392c0

…07345) (GH-107381)

(cherry picked from commit 9833052)

vstinner commented Jul 28, 2023

Copy link

Copy Markdown

Member

I will be avoid next 2 weeks. If you want to backport my recent C API doc fixes to 3.11 and 3.12, go ahead. My plan was to backport a batch of changes in a single commit to 3.12, and backport this one to 3.11. But I'm out of time now.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

vstinner commented Jul 28, 2023

Copy link

Copy Markdown

Member

I will be avoid next 2 weeks. If you want to backport my recent C API doc fixes to 3.11 and 3.12, go ahead

Aaaah, that's exactly what you did, thanks! :-)

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

serhiy-storchaka removed their assignment

Sep 8, 2023

Reviewers

vstinner

vstinner approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs

Documentation in the Doc dir

skip news topic-C-API

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

serhiy-storchaka commented Jul 27, 2023 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vstinner left a comment

Choose a reason for hiding this comment

Uh oh!

miss-islington commented Jul 27, 2023

Uh oh!

miss-islington commented Jul 27, 2023

Uh oh!

miss-islington commented Jul 27, 2023

Uh oh!

bedevere-bot commented Jul 28, 2023

Uh oh!

bedevere-bot commented Jul 28, 2023

Uh oh!

vstinner commented Jul 28, 2023

Uh oh!

vstinner commented Jul 28, 2023

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

serhiy-storchaka commented Jul 27, 2023 •

edited by github-actions Bot

Loading

Uh oh!

There was an error while loading. Please reload this page.