GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-106931: Fix the WASM Buildbots by ericsnowcurrently · Pull Request #107362 · python/cpython

Conversation

@ericsnowcurrently

@ericsnowcurrently ericsnowcurrently commented Jul 27, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

They don't support subinterpreters.

  • Issue: Global String Objects are Interned Only in the First Interpreter #106931

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@ericsnowcurrently
Skip subinterpreter tests when not supported.
eae92c3
@ericsnowcurrently ericsnowcurrently added the skip news label Jul 27, 2023
@bedevere-bot bedevere-bot mentioned this pull request Jul 27, 2023
Global String Objects are Interned Only in the First Interpreter #106931
Closed
@bedevere-bot bedevere-bot added awaiting core review tests Tests in the Lib/test dir labels Jul 27, 2023
@ericsnowcurrently ericsnowcurrently mentioned this pull request Jul 27, 2023
[3.12] gh-106931: Intern Statically Allocated Strings Globally (gh-107272) #107358
Closed
@ericsnowcurrently
ericsnowcurrently enabled auto-merge (squash) July 27, 2023 21:26
@ericsnowcurrently ericsnowcurrently mentioned this pull request Jul 27, 2023
gh-106931: Intern Statically Allocated Strings Globally #107272
Merged
@ericsnowcurrently
ericsnowcurrently merged commit 2f9bb77 into python:main Jul 27, 2023
@bedevere-bot bedevere-bot removed the awaiting core review label Jul 27, 2023
@ericsnowcurrently
ericsnowcurrently deleted the fix-wasm branch July 27, 2023 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@ericsnowcurrently @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.