GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.12] gh-106931: Intern Statically Allocated Strings Globally (gh-107272) by miss-islington · Pull Request #107358 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented Jul 27, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

We tried this before with a dict and for all interned strings. That ran into problems due to interpreter isolation. However, exclusively using a per-interpreter cache caused some inconsistency that can eliminate the benefit of interning. Here we circle back to using a global cache, but only for statically allocated strings. We also use a more-basic _Py_hashtable_t for that global cache instead of a dict.

Ideally we would only have the global cache, but the optional isolation of each interpreter's allocator means that a non-static string object must not outlive its interpreter. Thus we would have to store a copy of each such interned string in the global cache, tied to the main interpreter.
(cherry picked from commit b72947a)

Co-authored-by: Eric Snow [email protected]

  • Issue: Global String Objects are Interned Only in the First Interpreter #106931

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@ericsnowcurrently @miss-islington
pythongh-106931: Intern Statically Allocated Strings Globally (python…
b5cc1b6
…gh-107272)

We tried this before with a dict and for all interned strings.  That ran into problems due to interpreter isolation.  However, exclusively using a per-interpreter cache caused some inconsistency that can eliminate the benefit of interning.  Here we circle back to using a global cache, but only for statically allocated strings.  We also use a more-basic _Py_hashtable_t for that global cache instead of a dict.

Ideally we would only have the global cache, but the optional isolation of each interpreter's allocator means that a non-static string object must not outlive its interpreter.  Thus we would have to store a copy of each such interned string in the global cache, tied to the main interpreter.
(cherry picked from commit b72947a)

Co-authored-by: Eric Snow <[email protected]>
This was referenced Jul 27, 2023
Global String Objects are Interned Only in the First Interpreter #106931
Closed
gh-106931: Intern Statically Allocated Strings Globally #107272
Merged
@bedevere-bot bedevere-bot added the awaiting review label Jul 27, 2023
@ericsnowcurrently

ericsnowcurrently commented Jul 27, 2023

Copy link
Copy Markdown
Member

As noted elsewhere, I'm going to mull over whether or not this is worth it in 3.12.

CC @Yhg1s

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@ericsnowcurrently ericsnowcurrently added the DO-NOT-MERGE label Jul 27, 2023
@ericsnowcurrently
Update python3.12.abi
6e1b046
@ericsnowcurrently

ericsnowcurrently commented Jul 27, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

This also needs gh-107362.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@ericsnowcurrently
Skip subinterpreter tests when not supported.
eaeb49d
@ericsnowcurrently

ericsnowcurrently commented Jul 28, 2023

Copy link
Copy Markdown
Member

Having slept on it, I don't see this change as important enough to be worth backporting, particularly given the release manager's reservations.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@ericsnowcurrently ericsnowcurrently closed this Jul 28, 2023
@miss-islington
miss-islington deleted the backport-b72947a-3.12 branch July 28, 2023 16:42
@ericsnowcurrently

ericsnowcurrently commented Oct 4, 2023

Copy link
Copy Markdown
Member

This may be needed to fix gh-110279.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

This was referenced Oct 4, 2023
Dataclass takes no arguments in a subinterpreter in 3.12 #110279
Closed
[3.12] gh-106931: Intern Statically Allocated Strings Globally (gh-107272) #110713
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting review DO-NOT-MERGE

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@miss-islington @ericsnowcurrently @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.