GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-107306: Add a Doc Entry for Py_mod_multiple_interpreters by ericsnowcurrently · Pull Request #107403 · python/cpython

Conversation

@ericsnowcurrently

@ericsnowcurrently ericsnowcurrently commented Jul 28, 2023 •
edited by github-actions Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

It was added in 3.12 for PEP 684 (per-interpreter GIL).

  • Issue: Add a Docs Entry for the New Py_mod_multiple_interpreters Module Def Slot #107306

📚 Documentation preview 📚: https://cpython-previews--107403.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
ericsnowcurrently added 3 commits July 28, 2023 13:48
@ericsnowcurrently
Add a doc entry for Py_mod_multiple_interpreters.
6d2b9d2
@ericsnowcurrently
Clarify the doc entry.
987eb2a
@ericsnowcurrently
Add a ref.
2923576
@ericsnowcurrently ericsnowcurrently added docs Documentation in the Doc dir skip news needs backport to 3.12 only security fixes labels Jul 28, 2023
@bedevere-bot bedevere-bot mentioned this pull request Jul 28, 2023
Add a Docs Entry for the New Py_mod_multiple_interpreters Module Def Slot #107306
Closed
@bedevere-bot bedevere-bot added the awaiting core review label Jul 28, 2023
kumaraditya303
kumaraditya303 reviewed Jul 29, 2023
View reviewed changes
Comment thread Doc/c-api/module.rst

If ``Py_mod_multiple_interpreters`` is not specified, the import
machinery defaults to ``Py_MOD_MULTIPLE_INTERPRETERS_NOT_SUPPORTED``.

@kumaraditya303 kumaraditya303 Jul 29, 2023

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add .. versionadded:: 3.12?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
ericsnowcurrently reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@ericsnowcurrently
Add a versionadded.
b8b5eb3
@ericsnowcurrently
ericsnowcurrently merged commit fb344e9 into python:main Jul 31, 2023
@miss-islington

miss-islington commented Jul 31, 2023

Copy link
Copy Markdown
Contributor

Thanks @ericsnowcurrently for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting core review label Jul 31, 2023
@bedevere-bot

bedevere-bot commented Jul 31, 2023

Copy link
Copy Markdown

GH-107521 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.12 only security fixes label Jul 31, 2023
@ericsnowcurrently
ericsnowcurrently deleted the pep-684-docs-2 branch July 31, 2023 23:03
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 31, 2023
@ericsnowcurrently @miss-islington
pythongh-107306: Add a Doc Entry for Py_mod_multiple_interpreters (py…
47b6da2 
…thonGH-107403)

It was added in 3.12 for PEP 684 (per-interpreter GIL).
(cherry picked from commit fb344e9)

Co-authored-by: Eric Snow <[email protected]>
ericsnowcurrently added a commit that referenced this pull request Jul 31, 2023
@miss-islington @ericsnowcurrently
[3.12] gh-107306: Add a Doc Entry for Py_mod_multiple_interpreters (G…
3f6afaf 
…H-107403) (gh-107521)

gh-107306: Add a Doc Entry for Py_mod_multiple_interpreters (GH-107403)

It was added in 3.12 for PEP 684 (per-interpreter GIL).
(cherry picked from commit fb344e9)

Co-authored-by: Eric Snow <[email protected]>
@Eclips4 Eclips4 mentioned this pull request Jan 5, 2024
Add a Module Def Slot for Supporting Multiple Interpreters #104108
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kumaraditya303 kumaraditya303 kumaraditya303 left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@ericsnowcurrently @miss-islington @bedevere-bot @kumaraditya303
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.