GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-105751: Remove obsolete `object` base class in some ctypes tests by tomasr8 · Pull Request #107460 · python/cpython

Conversation

@tomasr8

@tomasr8 tomasr8 commented Jul 30, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Some classes in the ctypes tests still explicitly inherit from object which is a relic from Python 2.
Let's remove them. (This is a simple change so I think that a separate issue is not necessary?)

  • Issue: Rework test_ctypes #105751

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@tomasr8
Remove obsolete 'object' base class
c9cf04f
@bedevere-bot bedevere-bot added awaiting review tests Tests in the Lib/test dir labels Jul 30, 2023
@ambv ambv changed the title ctypes: Remove obsolete object base class in some test cases gh-105751: Remove obsolete object base class in some ctypes tests Jul 31, 2023
@bedevere-bot bedevere-bot mentioned this pull request Jul 31, 2023
Rework test_ctypes #105751
Closed
@ambv ambv added skip news needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Jul 31, 2023
@ambv
ambv merged commit 520efec into python:main Jul 31, 2023
@miss-islington

miss-islington commented Jul 31, 2023

Copy link
Copy Markdown
Contributor

Thanks @tomasr8 for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting review label Jul 31, 2023
@miss-islington

miss-islington commented Jul 31, 2023

Copy link
Copy Markdown
Contributor

Sorry, @tomasr8 and @ambv, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 520efecfc3aed34d3a44545c7cd872d1aea8c7dc 3.12
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington miss-islington assigned ambv Jul 31, 2023
@miss-islington

miss-islington commented Jul 31, 2023

Copy link
Copy Markdown
Contributor

Sorry, @tomasr8 and @ambv, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 520efecfc3aed34d3a44545c7cd872d1aea8c7dc 3.11
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@tomasr8
tomasr8 deleted the ctypes-remove-object branch July 31, 2023 13:34
ambv pushed a commit to ambv/cpython that referenced this pull request Jul 31, 2023
@tomasr8 @ambv
[3.12] pythongh-105751: Remove obsolete object base class in some c…
b4cc248 
…types tests (pythonGH-107460)

(cherry picked from commit 520efec)

Co-authored-by: Tomas R <[email protected]>
@bedevere-bot

bedevere-bot commented Jul 31, 2023

Copy link
Copy Markdown

GH-107501 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.12 only security fixes label Jul 31, 2023
ambv pushed a commit to ambv/cpython that referenced this pull request Jul 31, 2023
@tomasr8 @ambv
[3.11] pythongh-105751: Remove obsolete object base class in some c…
8845ce1 
…types tests (pythonGH-107460)

(cherry picked from commit 520efec)

Co-authored-by: Tomas R <[email protected]>
@bedevere-bot

bedevere-bot commented Jul 31, 2023

Copy link
Copy Markdown

GH-107502 is a backport of this pull request to the 3.11 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Jul 31, 2023
ambv added a commit that referenced this pull request Jul 31, 2023
@ambv @tomasr8
[3.11] gh-105751: Remove obsolete object base class in some ctypes …
1b40431 
…tests (GH-107460) (#107502)

(cherry picked from commit 520efec)

Co-authored-by: Tomas R <[email protected]>
ambv added a commit that referenced this pull request Jul 31, 2023
@ambv @tomasr8
[3.12] gh-105751: Remove obsolete object base class in some ctypes …
831fd19 
…tests (GH-107460) (#107501)

(cherry picked from commit 520efec)

Co-authored-by: Tomas R <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@ambv ambv

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@tomasr8 @miss-islington @bedevere-bot @ambv
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.