GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-104146: Remove dead code from Argument Clinic by erlend-aasland · Pull Request #107555 · python/cpython

Conversation

@erlend-aasland

@erlend-aasland erlend-aasland commented Aug 2, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Remove commented out lines from clinic.py

  • Issue: Remove dead code from clinic.py #104146

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@erlend-aasland
pythongh-104146: Remove dead code from Argument Clinic
8c3e9fa 
Remove commented out lines from clinic.py
@erlend-aasland
erlend-aasland requested a review from AlexWaygood as a code owner August 2, 2023 08:41
@erlend-aasland erlend-aasland added the skip news label Aug 2, 2023
@bedevere-bot bedevere-bot added the awaiting core review label Aug 2, 2023
@bedevere-bot bedevere-bot mentioned this pull request Aug 2, 2023
Remove dead code from clinic.py #104146
Closed
@AlexWaygood

AlexWaygood commented Aug 2, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

There's an unused import of Callable in cpp.py as well, want to tackle that while we're here? :)

It doesn't feel like it deserves its own PR
erlend-aasland reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland
Remove unused import from cpp
3e200bb
AlexWaygood
AlexWaygood approved these changes Aug 2, 2023
View reviewed changes

@AlexWaygood AlexWaygood left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💀

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
erlend-aasland reacted with rocket emoji
All reactions
  • 🚀 1 reaction
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Aug 2, 2023
@erlend-aasland
erlend-aasland enabled auto-merge (squash) August 2, 2023 08:55
@erlend-aasland erlend-aasland linked an issue Aug 2, 2023 that may be closed by this pull request
Remove dead code from clinic.py #104146
Closed
@erlend-aasland
erlend-aasland merged commit 439466a into python:main Aug 2, 2023
@bedevere-bot bedevere-bot removed the awaiting merge label Aug 2, 2023
@erlend-aasland
erlend-aasland deleted the clinic/remove-dead-code branch August 2, 2023 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AlexWaygood AlexWaygood AlexWaygood approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remove dead code from clinic.py

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@erlend-aasland @AlexWaygood @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.