GeezerVison is showing github.com — gh-104146: Argument clinic: remove unused methods and variables by AlexWaygood · Pull Request #107608 · python/cpython
Conversation
AlexWaygood
commented
Aug 3, 2023
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
- The
i variable in version_comparitor was unused (it was a useless use of enumerate; we can just iterate directly over the iterator).
- The methods
IndentStack.indent(), DSLParser.calculate_indent(), cpp.Monitor.close() and cpp.Monitor.write() all have no test coverage. They are not used or referenced anywhere in Tools/clinic; the test suite passes without them; mypy and pyflakes pass without them; and Python builds without them. I think they can all be removed.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. make clinic also does not complain.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
AlexWaygood reacted with thumbs up emoji
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.