GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-104146: Argument clinic: remove dead code highlighted by the `vulture` tool by AlexWaygood · Pull Request #107632 · python/cpython

Conversation

@AlexWaygood

@AlexWaygood AlexWaygood commented Aug 4, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

(We definitely shouldn't run vulture on clinic.py in CI -- it has a ton of false positives.)

  • Issue: Remove dead code from clinic.py #104146

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@AlexWaygood
Argument clinic: remove dead code highlighted by the vulture tool
638204b
@AlexWaygood AlexWaygood added the skip news label Aug 4, 2023
@AlexWaygood
AlexWaygood requested a review from erlend-aasland as a code owner August 4, 2023 13:59
@bedevere-bot bedevere-bot mentioned this pull request Aug 4, 2023
Remove dead code from clinic.py #104146
Closed
@bedevere-bot bedevere-bot added the awaiting core review label Aug 4, 2023
erlend-aasland
erlend-aasland reviewed Aug 4, 2023
View reviewed changes
Comment thread Tools/clinic/clinic.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@AlexWaygood
Block docstring fixups
6a0fdda
erlend-aasland
erlend-aasland approved these changes Aug 4, 2023
View reviewed changes

@erlend-aasland erlend-aasland left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
AlexWaygood reacted with rocket emoji
All reactions
  • 🚀 1 reaction
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Aug 4, 2023
@AlexWaygood
AlexWaygood enabled auto-merge (squash) August 4, 2023 14:30
@AlexWaygood
AlexWaygood merged commit 407d7fd into python:main Aug 4, 2023
@bedevere-bot bedevere-bot removed the awaiting merge label Aug 4, 2023
@AlexWaygood
AlexWaygood deleted the clinic-vulture branch August 4, 2023 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erlend-aasland erlend-aasland erlend-aasland approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@AlexWaygood @erlend-aasland @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.