GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — GH-106684: raise ResourceWarning when StreamWriter is not closed by kumaraditya303 · Pull Request #107650 · python/cpython

Conversation

@kumaraditya303

@kumaraditya303 kumaraditya303 commented Aug 5, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor
  • Issue: asyncio: potential leak of TLS connections #106684

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@kumaraditya303
raise ResourceWarning when StreamWriter is not closed
5e86cdf
@bedevere-bot bedevere-bot mentioned this pull request Aug 5, 2023
asyncio: potential leak of TLS connections #106684
Closed
@kumaraditya303
fix lint
066d128
@kumaraditya303

kumaraditya303 commented Aug 5, 2023

Copy link
Copy Markdown
Contributor Author

Memray flamegraphs of code on issue.

Before:
before
After:
after
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@kumaraditya303
add test
f11cef0
@kumaraditya303 kumaraditya303 added type-bug An unexpected behavior, bug, or error topic-asyncio needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Aug 5, 2023
@blurb-it
📜🤖 Added by blurb_it.
1e9f902
@kumaraditya303
kumaraditya303 marked this pull request as ready for review August 5, 2023 05:28
@kumaraditya303
kumaraditya303 requested review from 1st1, asvetlov, gvanrossum and willingc as code owners August 5, 2023 05:28
@bedevere-bot bedevere-bot added the awaiting core review label Aug 5, 2023
asvetlov
asvetlov approved these changes Aug 5, 2023
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Aug 5, 2023
@kumaraditya303
kumaraditya303 merged commit 41178e4 into python:main Aug 5, 2023
@miss-islington

miss-islington commented Aug 5, 2023

Copy link
Copy Markdown
Contributor

Thanks @kumaraditya303 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting merge label Aug 5, 2023
@kumaraditya303
kumaraditya303 deleted the leak branch August 5, 2023 12:18
@bedevere-bot

bedevere-bot commented Aug 5, 2023

Copy link
Copy Markdown

GH-107656 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.12 only security fixes label Aug 5, 2023
@bedevere-bot

bedevere-bot commented Aug 5, 2023

Copy link
Copy Markdown

GH-107657 is a backport of this pull request to the 3.11 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Aug 5, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 5, 2023
@kumaraditya303 @miss-islington
pythonGH-106684: raise ResourceWarning when asyncio.StreamWriter …
0004686 
…is not closed (pythonGH-107650)

(cherry picked from commit 41178e4)

Co-authored-by: Kumar Aditya <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 5, 2023
@kumaraditya303 @miss-islington
pythonGH-106684: raise ResourceWarning when asyncio.StreamWriter …
385390a 
…is not closed (pythonGH-107650)

(cherry picked from commit 41178e4)

Co-authored-by: Kumar Aditya <[email protected]>
evildmp pushed a commit to evildmp/cpython that referenced this pull request Aug 5, 2023
@kumaraditya303 @evildmp
pythonGH-106684: raise ResourceWarning when asyncio.StreamWriter …
d999392 
…is not closed (python#107650)
@bedevere-bot

bedevere-bot commented Aug 10, 2023

Copy link
Copy Markdown

GH-107656 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Yhg1s pushed a commit that referenced this pull request Aug 10, 2023
@miss-islington @kumaraditya303
[3.12] GH-106684: Close asyncio.StreamWriter when `asyncio.StreamWr…
7853c76 
…iter` is not closed by application (GH-107650) (#107656)

GH-106684: raise `ResourceWarning` when `asyncio.StreamWriter` is not closed (GH-107650)
(cherry picked from commit 41178e4)

Co-authored-by: Kumar Aditya <[email protected]>
Co-authored-by: Kumar Aditya <[email protected]>
@miss-islington miss-islington mentioned this pull request Aug 10, 2023
[3.11] [3.12] GH-106684: Close asyncio.StreamWriter when asyncio.StreamWriter is not closed by application (GH-107650) (GH-107656) #107836
Merged
miss-islington added a commit to miss-islington/cpython that referenced this pull request Aug 10, 2023
@miss-islington @kumaraditya303
[3.12] pythonGH-106684: Close asyncio.StreamWriter when `asyncio.St…
91ce3ac 
…reamWriter` is not closed by application (pythonGH-107650) (pythonGH-107656)

pythonGH-106684: raise `ResourceWarning` when `asyncio.StreamWriter` is not closed (pythonGH-107650)
(cherry picked from commit 41178e4)

(cherry picked from commit 7853c76)

Co-authored-by: Miss Islington (bot) <[email protected]>
Co-authored-by: Kumar Aditya <[email protected]>
Co-authored-by: Kumar Aditya <[email protected]>
kumaraditya303 added a commit that referenced this pull request Aug 10, 2023
@miss-islington @kumaraditya303
[3.11] [3.12] GH-106684: Close asyncio.StreamWriter when `asyncio.S…
fb08b79 
…treamWriter` is not closed by application (GH-107650) (GH-107656) (#107836)

[3.12] GH-106684:  Close `asyncio.StreamWriter` when `asyncio.StreamWriter` is not closed by application (GH-107650) (GH-107656)

GH-106684: raise `ResourceWarning` when `asyncio.StreamWriter` is not closed (GH-107650)
(cherry picked from commit 41178e4)

(cherry picked from commit 7853c76)

Co-authored-by: Kumar Aditya <[email protected]>
@Rongronggg9 Rongronggg9 mentioned this pull request Sep 7, 2023
ConnectionResetError: Cannot write to closing transport romis2012/aiohttp-socks#27
Closed
@bmerry bmerry mentioned this pull request Sep 11, 2023
Restore time_sync module on macOS ska-sa/aiokatcp#75
Merged
@bmerry bmerry mentioned this pull request Sep 18, 2023
3.11.5 regression: StreamWriter.__del__ fails if event loop is already closed #109538
Closed
@gvanrossum gvanrossum mentioned this pull request Feb 19, 2024
Abandoned StreamWriter isn't reliably detected #114914
Closed
@Andrew-Dickinson Andrew-Dickinson mentioned this pull request Dec 20, 2024
ospfclient: fix crash due to streamwriter garbage collect FRRouting/frr#17700
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@asvetlov asvetlov asvetlov approved these changes
@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner
@gvanrossum gvanrossum Awaiting requested review from gvanrossum
@willingc willingc Awaiting requested review from willingc willingc is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

topic-asyncio type-bug An unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@kumaraditya303 @miss-islington @bedevere-bot @asvetlov
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.