GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-104496: Use correct Tcl or Tk version in Tkinter tests by serhiy-storchaka · Pull Request #107688 · python/cpython

Conversation

@serhiy-storchaka

@serhiy-storchaka serhiy-storchaka commented Aug 6, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

In future Tcl and Tk versions can be desynchronized.

  • Issue: Tcl and Tk versions can be desynchronized #107687
  • Issue: Tkinter, IDLE: Future Tcl and Tk can have differing version/patchlevel #104496

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@serhiy-storchaka serhiy-storchaka added tests Tests in the Lib/test dir needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Aug 6, 2023
@bedevere-bot bedevere-bot added the awaiting core review label Aug 6, 2023
@bedevere-bot bedevere-bot mentioned this pull request Aug 6, 2023
Tcl and Tk versions can be desynchronized #107687
Closed
@serhiy-storchaka serhiy-storchaka changed the title gh-107687: Use correct Tcl or Tk version in Tkinter tests gh-104496: Use correct Tcl or Tk version in Tkinter tests Aug 6, 2023
@bedevere-bot bedevere-bot mentioned this pull request Aug 6, 2023
Tkinter, IDLE: Future Tcl and Tk can have differing version/patchlevel #104496
Closed
@serhiy-storchaka serhiy-storchaka added the skip news label Aug 7, 2023
@serhiy-storchaka
serhiy-storchaka force-pushed the tests-tk-version branch 2 times, most recently from 5c385fb to 098ead2 Compare August 7, 2023 08:51
@serhiy-storchaka
pythongh-107687: Use correct Tcl or Tk version in Tkinter tests
c1d8f26 
In future Tcl and Tk versions can be desynchronized.
@serhiy-storchaka
serhiy-storchaka force-pushed the tests-tk-version branch from 098ead2 to c1d8f26 Compare August 7, 2023 10:22
@serhiy-storchaka
serhiy-storchaka merged commit 3c8e8f3 into python:main Aug 7, 2023
@miss-islington

miss-islington commented Aug 7, 2023

Copy link
Copy Markdown
Contributor

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting core review label Aug 7, 2023
@serhiy-storchaka
serhiy-storchaka deleted the tests-tk-version branch August 7, 2023 11:11
@miss-islington

miss-islington commented Aug 7, 2023

Copy link
Copy Markdown
Contributor

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 3c8e8f3ceeae08fc43d885f5a4c65a3ee4b1a2c8 3.11
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington miss-islington assigned serhiy-storchaka Aug 7, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 7, 2023
@serhiy-storchaka @miss-islington
pythongh-104496: Use correct Tcl or Tk version in Tkinter tests (pyth…
185f71b 
…onGH-107688)

In future Tcl and Tk versions can be desynchronized.
(cherry picked from commit 3c8e8f3)

Co-authored-by: Serhiy Storchaka <[email protected]>
@bedevere-bot

bedevere-bot commented Aug 7, 2023

Copy link
Copy Markdown

GH-107709 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.12 only security fixes label Aug 7, 2023
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request Aug 7, 2023
@serhiy-storchaka
[3.11] pythongh-104496: Use correct Tcl or Tk version in Tkinter tests (
d978b04 
pythonGH-107688)

In future Tcl and Tk versions can be desynchronized..
(cherry picked from commit 3c8e8f3)

Co-authored-by: Serhiy Storchaka <[email protected]>
@bedevere-bot

bedevere-bot commented Aug 7, 2023

Copy link
Copy Markdown

GH-107719 is a backport of this pull request to the 3.11 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Aug 7, 2023
serhiy-storchaka added a commit that referenced this pull request Aug 7, 2023
@serhiy-storchaka
[3.11] gh-104496: Use correct Tcl or Tk version in Tkinter tests (GH-…
81c8f7d 
…107688) (GH-107719)

In future Tcl and Tk versions can be desynchronized.
(cherry picked from commit 3c8e8f3)
Yhg1s pushed a commit that referenced this pull request Aug 16, 2023
@miss-islington @serhiy-storchaka
[3.12] gh-104496: Use correct Tcl or Tk version in Tkinter tests (GH-…
91d935b 
…107688) (#107709)

gh-104496: Use correct Tcl or Tk version in Tkinter tests (GH-107688)

In future Tcl and Tk versions can be desynchronized.
(cherry picked from commit 3c8e8f3)

Co-authored-by: Serhiy Storchaka <[email protected]>
@serhiy-storchaka serhiy-storchaka removed their assignment Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@serhiy-storchaka @miss-islington @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.