GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-107755: Document the correct default value of slice step by wimglenn · Pull Request #107756 · python/cpython

Conversation

@wimglenn

@wimglenn wimglenn commented Aug 8, 2023 •
edited by github-actions Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor
  • Issue: Signature of slice is documented incorrectly #107755

📚 Documentation preview 📚: https://cpython-previews--107756.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot mentioned this pull request Aug 8, 2023
Signature of slice is documented incorrectly #107755
Closed
@bedevere-bot bedevere-bot added awaiting review docs Documentation in the Doc dir skip news labels Aug 8, 2023
@AA-Turner AA-Turner added needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Aug 8, 2023
AA-Turner
AA-Turner approved these changes Aug 8, 2023
View reviewed changes
@bedevere-bot bedevere-bot added awaiting core review and removed awaiting review labels Aug 8, 2023
sunmy2019
sunmy2019 approved these changes Aug 8, 2023
View reviewed changes
rhettinger
rhettinger approved these changes Aug 13, 2023
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Aug 13, 2023
@wimglenn
Document the correct default value of slice step. Closes python#107755
c9098a1
@wimglenn
wimglenn force-pushed the slice-step-default branch from d0d5d0a to c9098a1 Compare August 15, 2023 03:31
@encukou
encukou merged commit 9bf350b into python:main Sep 5, 2023
@miss-islington

miss-islington commented Sep 5, 2023

Copy link
Copy Markdown
Contributor

Thanks @wimglenn for the PR, and @encukou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting merge label Sep 5, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 5, 2023
@wimglenn @miss-islington
pythongh-107755: Document the correct default value of slice step (py…
c056ba4 
…thonGH-107756)

Document the correct default value of slice step.
(cherry picked from commit 9bf350b)

Co-authored-by: wim glenn <[email protected]>
@bedevere-bot

bedevere-bot commented Sep 5, 2023

Copy link
Copy Markdown

GH-108955 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.12 only security fixes label Sep 5, 2023
@bedevere-bot

bedevere-bot commented Sep 5, 2023

Copy link
Copy Markdown

GH-108956 is a backport of this pull request to the 3.11 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Sep 5, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 5, 2023
@wimglenn @miss-islington
pythongh-107755: Document the correct default value of slice step (py…
b36cb9e 
…thonGH-107756)

Document the correct default value of slice step.
(cherry picked from commit 9bf350b)

Co-authored-by: wim glenn <[email protected]>
@wimglenn
wimglenn deleted the slice-step-default branch September 5, 2023 20:09
vstinner pushed a commit that referenced this pull request Sep 7, 2023
@miss-islington @wimglenn
[3.11] gh-107755: Document the correct default value of slice step (G…
1f115a8 
…H-107756) (#108956)

gh-107755: Document the correct default value of slice step (GH-107756)

Document the correct default value of slice step.
(cherry picked from commit 9bf350b)

Co-authored-by: wim glenn <[email protected]>
Yhg1s pushed a commit that referenced this pull request Sep 8, 2023
@miss-islington @wimglenn
[3.12] gh-107755: Document the correct default value of slice step (G…
eeaae92 
…H-107756) (#108955)

gh-107755: Document the correct default value of slice step (GH-107756)

Document the correct default value of slice step.
(cherry picked from commit 9bf350b)

Co-authored-by: wim glenn <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rhettinger rhettinger rhettinger approved these changes
@AA-Turner AA-Turner AA-Turner approved these changes
@sunmy2019 sunmy2019 sunmy2019 approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@wimglenn @miss-islington @bedevere-bot @rhettinger @AA-Turner @sunmy2019 @encukou
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.