GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-104683: Add --exclude option to Argument Clinic CLI by erlend-aasland · Pull Request #107770 · python/cpython

Conversation

@erlend-aasland

@erlend-aasland erlend-aasland commented Aug 8, 2023 •
edited by github-actions Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Explicitly exclude Lib/test/clinic.test.c when running make clinic.

  • Issue: Modernise code in Tools/clinic/ #104683

📚 Documentation preview 📚: https://cpython-previews--107770.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@erlend-aasland
pythongh-104683: Add --exclude option to Argument Clinic CLI
bb701b7 
Explicitly exclude Lib/test/clinic.test.c when running make clinic.
@erlend-aasland
erlend-aasland requested a review from AlexWaygood as a code owner August 8, 2023 10:23
@erlend-aasland
erlend-aasland requested a review from serhiy-storchaka August 8, 2023 10:23
@bedevere-bot bedevere-bot added the awaiting core review label Aug 8, 2023
@bedevere-bot bedevere-bot mentioned this pull request Aug 8, 2023
Modernise code in Tools/clinic/ #104683
Closed
5 of 7 tasks
@erlend-aasland erlend-aasland mentioned this pull request Aug 8, 2023
gh-104683: Rename clinic.test => clinic.test.c #106443
Merged
erlend-aasland added 3 commits August 8, 2023 12:25
@erlend-aasland
Wording
3337074
@erlend-aasland
Wording
14fcaf0
@erlend-aasland
Default ""
59908be
serhiy-storchaka
serhiy-storchaka reviewed Aug 8, 2023
View reviewed changes

@serhiy-storchaka serhiy-storchaka left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great idea!

Could you please update also the makefile? And add a target clinic-tests which regenerate specifically the test file?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
erlend-aasland reacted with heart emoji
All reactions
  • ❤️ 1 reaction
Comment thread Tools/clinic/clinic.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Tools/clinic/clinic.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland

erlend-aasland commented Aug 8, 2023

Copy link
Copy Markdown
Contributor Author

Great idea!

Thank you!

Could you please update also the makefile? And add a target clinic-tests which regenerate specifically the test file?

That is a very good idea.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland
Normalise paths, provide better UX, and add clinic-tests make target
a2787bc
@erlend-aasland
erlend-aasland requested a review from serhiy-storchaka August 8, 2023 10:59
serhiy-storchaka
serhiy-storchaka approved these changes Aug 8, 2023
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Aug 8, 2023
@erlend-aasland
Add test
352f30d
@erlend-aasland
erlend-aasland enabled auto-merge (squash) August 8, 2023 11:28
serhiy-storchaka
serhiy-storchaka reviewed Aug 8, 2023
View reviewed changes
Comment thread Lib/test/test_clinic.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Lib/test/test_clinic.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@AlexWaygood
AlexWaygood disabled auto-merge August 8, 2023 11:42
erlend-aasland added 2 commits August 8, 2023 22:15
@erlend-aasland
Pull in main
87f4d8d
@erlend-aasland
Address review
8d837c0
@erlend-aasland
erlend-aasland enabled auto-merge (squash) August 8, 2023 20:22
@erlend-aasland
erlend-aasland merged commit 0be3743 into python:main Aug 8, 2023
@bedevere-bot bedevere-bot removed the awaiting merge label Aug 8, 2023
@erlend-aasland
erlend-aasland deleted the clinic/cli-exclude-files branch August 8, 2023 21:11
erlend-aasland added a commit to erlend-aasland/devguide that referenced this pull request Sep 8, 2023
@erlend-aasland @serhiy-storchaka
gh-104683: Add --exclude option to Argument Clinic CLI (python/cpytho…
832ccfa 
…n#107770)

Co-authored-by: Serhiy Storchaka <[email protected]>
AA-Turner pushed a commit to AA-Turner/devguide that referenced this pull request Sep 13, 2023
@erlend-aasland @serhiy-storchaka
python/cpython#104683: Add --exclude option to Argument Clinic CLI (p…
8dd6936 
…ython/cpython#107770)

Co-authored-by: Serhiy Storchaka <[email protected]>
erlend-aasland added a commit to python/devguide that referenced this pull request Sep 26, 2023
@erlend-aasland @serhiy-storchaka
python/cpython#104683: Add --exclude option to Argument Clinic CLI (p…
2d0204d 
…ython/cpython#107770)

Co-authored-by: Serhiy Storchaka <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes
@AlexWaygood AlexWaygood Awaiting requested review from AlexWaygood

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@erlend-aasland @serhiy-storchaka @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.