GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — GH-107803: double linked list implementation for asyncio tasks by kumaraditya303 · Pull Request #107804 · python/cpython

Conversation

@kumaraditya303

@kumaraditya303 kumaraditya303 commented Aug 9, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor
  • Issue: Double linked list implementation for asyncio tasks #107803

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
itamaro, jbower-fb, and kPsarakis reacted with hooray emoji itamaro and kPsarakis reacted with eyes emoji
All reactions
  • 🎉 3 reactions
  • 👀 2 reactions
kumaraditya303 and others added 13 commits May 26, 2023 11:08
@kumaraditya303
linked list
cc66eeb
@kumaraditya303
add tail optmiization to linked list
d5a3d87
@kumaraditya303
wip
a0c5fcf
@kumaraditya303
wip
77d012f
@kumaraditya303
wip
5d9653d
@kumaraditya303
Merge branch 'main' of https://github.com/python/cpython into linked-…
5a00198 
…list
@kumaraditya303
Merge branch 'main' of https://github.com/python/cpython into linked-…
4cdc834 
…list
@kumaraditya303
more fixes
35a00f1
@kumaraditya303
Merge branch 'main' of https://github.com/python/cpython into linked-…
fddb9d6 
…list
@kumaraditya303
finally it works
1d32835
@kumaraditya303
Merge branch 'main' of https://github.com/python/cpython into linked-…
b46bcfe 
…list
@kumaraditya303
Merge branch 'main' of https://github.com/python/cpython into linked-…
ee7ead2 
…list
@kumaraditya303
add tests
af0280a
@bedevere-bot bedevere-bot mentioned this pull request Aug 9, 2023
Double linked list implementation for asyncio tasks #107803
Closed
@kumaraditya303
kumaraditya303 force-pushed the linked-list branch 2 times, most recently from 8d57b5a to af0280a Compare August 9, 2023 10:28
@kumaraditya303 kumaraditya303 added performance Performance or resource usage topic-asyncio 🔨 test-with-buildbots Test PR w/ buildbots; report in status section labels Aug 9, 2023
@bedevere-bot

bedevere-bot commented Aug 9, 2023

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @kumaraditya303 for commit af0280a 🤖

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Aug 9, 2023
@kumaraditya303
kumaraditya303 marked this pull request as ready for review August 9, 2023 17:38
@kumaraditya303
kumaraditya303 requested review from 1st1, asvetlov, gvanrossum and willingc as code owners August 9, 2023 17:38
@bedevere-bot bedevere-bot added the awaiting core review label Aug 9, 2023
@kumaraditya303

kumaraditya303 commented Aug 9, 2023

Copy link
Copy Markdown
Contributor Author

I'll add Whats's New entry for this later together with other performance improvements so skipping news for now.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@kumaraditya303 kumaraditya303 added the skip news label Aug 9, 2023
@gvanrossum

gvanrossum commented Aug 9, 2023

Copy link
Copy Markdown
Member

Is there someone else who could review this? I am currently scrambling.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@kumaraditya303
Merge branch 'main' into linked-list
457739a
itamaro
itamaro reviewed Aug 21, 2023
View reviewed changes
Comment thread Modules/_asynciomodule.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Modules/_asynciomodule.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
kumaraditya303 added 2 commits August 24, 2023 13:09
@kumaraditya303
Merge branch 'main' of https://github.com/python/cpython into linked-…
4670731 
…list
@kumaraditya303
fix tests and couple c implmentation to c task
e061081 
improved linked-list logic and more comments
itamaro
itamaro reviewed Aug 26, 2023
View reviewed changes
Comment thread Lib/test/test_asyncio/test_tasks.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Modules/_asynciomodule.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
kumaraditya303 added 2 commits August 30, 2023 05:24
@kumaraditya303
Merge branch 'main' of https://github.com/python/cpython into linked-…
836d254 
…list
@kumaraditya303
fix test
efce4b3
@willingc

willingc commented Jun 21, 2024

Copy link
Copy Markdown
Contributor

@kumaraditya303 @itamaro I'm going to mark this "Awaiting changes" due to the merge conflict and the amount of time that has passed since it was opened. If after fixing the changes, you would like to have this reviewed again, please ping. Thanks!
itamaro reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@willingc willingc added the awaiting changes label Jun 21, 2024
@kumaraditya303
kumaraditya303 marked this pull request as draft June 21, 2024 10:35
@bedevere-app bedevere-app Bot removed awaiting core review awaiting changes labels Jun 21, 2024
@kumaraditya303
Merge branch 'main' of https://github.com/python/cpython into linked-…
c7b604c 
…list
@kumaraditya303 kumaraditya303 added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jun 21, 2024
@bedevere-bot

bedevere-bot commented Jun 21, 2024

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @kumaraditya303 for commit c7b604c 🤖

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Jun 21, 2024
@kumaraditya303
Merge branch 'main' of https://github.com/python/cpython into linked-…
56beb04 
…list
@kumaraditya303
kumaraditya303 marked this pull request as ready for review June 22, 2024 12:55
@bedevere-app bedevere-app Bot added the awaiting core review label Jun 22, 2024
willingc
willingc approved these changes Jun 22, 2024
View reviewed changes

@willingc willingc left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me @kumaraditya303. Let's merge this and thanks for rebooting the PR.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Jun 22, 2024
@willingc
willingc merged commit 4717aaa into python:main Jun 22, 2024
@bedevere-app bedevere-app Bot removed the awaiting merge label Jun 22, 2024
@willingc

willingc commented Jun 22, 2024

Copy link
Copy Markdown
Contributor

@kumaraditya303 I wasn't sure if we wanted to backport. Please do so if it makes sense. Thanks!
nineteendo reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@kumaraditya303
kumaraditya303 deleted the linked-list branch June 23, 2024 04:24
mrahtz pushed a commit to mrahtz/cpython that referenced this pull request Jun 30, 2024
@kumaraditya303 @itamaro @mrahtz
pythonGH-107803: double linked list implementation for asyncio tasks (p…
797d82f 
…ythonGH-107804)

* linked list

* add tail optmiization to linked list

* wip

* wip

* wip

* more fixes

* finally it works

* add tests

* remove weakreflist

* add some comments

* reduce code duplication in _asynciomodule.c

* address some review comments

* add invariants about the state of the linked list

* add better explanation

* clinic regen

* reorder branches for better branch prediction

* Update Modules/_asynciomodule.c

* Apply suggestions from code review

Co-authored-by: Itamar Oren <[email protected]>

* fix capturing of eager tasks

* add comment to task finalization

* fix tests and couple c implmentation to c task

improved linked-list logic and more comments

* fix test

---------

Co-authored-by: Itamar Oren <[email protected]>
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@kumaraditya303 @itamaro @estyxx
pythonGH-107803: double linked list implementation for asyncio tasks (p…
c5a0305 
…ythonGH-107804)

* linked list

* add tail optmiization to linked list

* wip

* wip

* wip

* more fixes

* finally it works

* add tests

* remove weakreflist

* add some comments

* reduce code duplication in _asynciomodule.c

* address some review comments

* add invariants about the state of the linked list

* add better explanation

* clinic regen

* reorder branches for better branch prediction

* Update Modules/_asynciomodule.c

* Apply suggestions from code review

Co-authored-by: Itamar Oren <[email protected]>

* fix capturing of eager tasks

* add comment to task finalization

* fix tests and couple c implmentation to c task

improved linked-list logic and more comments

* fix test

---------

Co-authored-by: Itamar Oren <[email protected]>
@kumaraditya303
kumaraditya303 restored the linked-list branch April 18, 2025 19:31
@kumaraditya303
kumaraditya303 deleted the linked-list branch April 18, 2025 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@itamaro itamaro itamaro approved these changes
@willingc willingc willingc approved these changes
@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner
@asvetlov asvetlov Awaiting requested review from asvetlov asvetlov is a code owner
@gvanrossum gvanrossum Awaiting requested review from gvanrossum

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

performance Performance or resource usage skip news topic-asyncio

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@kumaraditya303 @bedevere-bot @gvanrossum @itamaro @willingc
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.