GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.12] gh-106844: Fix issues in _winapi.LCMapStringEx (GH-107832) by serhiy-storchaka · Pull Request #107874 · python/cpython

Conversation

@serhiy-storchaka

@serhiy-storchaka serhiy-storchaka commented Aug 11, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Strings with length from 2**31-1 to 2**32-2 always caused MemoryError, it doesn't matter how much memory is available.
  • Strings with length exactly 2**32-1 caused OSError.
  • Strings longer than 2**32-1 characters were truncated due to integer overflow bug.
  • Strings containing the null character were truncated at the first null character.

Now strings longer than 2**31-1 characters caused OverflowError and the null character is allowed.
(cherry picked from commit 04cc014)

  • Issue: _winapi.LCMapStringEx fails when encountering a string containing null characters #106844

Closes #106844

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@serhiy-storchaka
[3.12] pythongh-106844: Fix issues in _winapi.LCMapStringEx (pythonGH…
21a0b8d
…-107832)

* Strings with length from 2**31-1 to 2**32-2 always caused MemoryError,
   it doesn't matter how much memory is available.
* Strings with length exactly 2**32-1 caused OSError.
* Strings longer than 2**32-1 characters were truncated due to integer overflow bug.
* Strings containing the null character were truncated at the first null character.

Now strings longer than 2**31-1 characters caused OverflowError and the null character is allowed..
(cherry picked from commit 04cc014)

Co-authored-by: Serhiy Storchaka <[email protected]>
This was referenced Aug 11, 2023
_winapi.LCMapStringEx fails when encountering a string containing null characters #106844
Closed
gh-106844: Fix null-bytes handling in LCMapStringEx in _winapi #107832
Merged
@bedevere-bot bedevere-bot added the awaiting core review label Aug 11, 2023
@zooba zooba mentioned this pull request Aug 15, 2023
[3.12] gh-106242: Fix path truncation in os.path.normpath (GH-106816) #107981
Merged
@Yhg1s
Yhg1s merged commit b5176a8 into python:3.12 Aug 16, 2023
@bedevere-bot bedevere-bot removed the awaiting core review label Aug 16, 2023
@serhiy-storchaka
serhiy-storchaka deleted the backport-04cc014-3.12 branch August 16, 2023 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@serhiy-storchaka @Yhg1s @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.