GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.12] gh-106242: Fix path truncation in os.path.normpath (GH-106816) by zooba · Pull Request #107981 · python/cpython

Conversation

@zooba

@zooba zooba commented Aug 15, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: os.path.normpath truncates input on null bytes in 3.11, but not 3.10 #106242

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@finnagin @zooba
pythongh-106242: Fix path truncation in os.path.normpath (pythonGH-10…
828d1ef 
…6816)
This was referenced Aug 15, 2023
os.path.normpath truncates input on null bytes in 3.11, but not 3.10 #106242
Closed
gh-106242: Fix path truncation in normpath #106816
Merged
@bedevere-bot bedevere-bot added the awaiting core review label Aug 15, 2023
serhiy-storchaka and others added 2 commits August 15, 2023 17:23
@serhiy-storchaka @zooba
pythongh-106844: Fix issues in _winapi.LCMapStringEx (pythonGH-107832)
5d83c72 
* Strings with length from 2**31-1 to 2**32-2 always caused MemoryError,
   it doesn't matter how much memory is available.
* Strings with length exactly 2**32-1 caused OSError.
* Strings longer than 2**32-1 characters were truncated due to integer overflow bug.
* Strings containing the null character were truncated at the first null character.

Now strings longer than 2**31-1 characters caused OverflowError and the null character is allowed.
@zooba
pythongh-106242: Minor fixup to avoid compiler warnings
eadabd8
@zooba

zooba commented Aug 15, 2023

Copy link
Copy Markdown
Member Author

This relies on the fix in #107874 so I picked it into this PR. If the other PR is merged before then it should just disappear.

I also pre-backported #107983 to avoid a couple of compiler warnings.

@Yhg1s If you're okay with this (and #107874), would be good to have this 3.11 regression fixed in all 3.12 releases. It will get fixed in 3.11, but probably not the end of the world if it lands in 3.12.1.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ambv

ambv commented Aug 15, 2023

Copy link
Copy Markdown
Contributor

Up to Thomas what to do with 3.12, I approved the 3.11 change.
zooba reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Yhg1s

Yhg1s commented Aug 16, 2023

Copy link
Copy Markdown
Member

#107874 was merged, so this needs double-checking that it's not unnecessarily (now) duplicating things. It's fine to get this into 3.12.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@zooba
Merge branch '3.12' into pythongh-106242-3.12
196575b
@zooba

zooba commented Aug 16, 2023

Copy link
Copy Markdown
Member Author

After the merge it's back down to the original change, so looks good to go
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@AA-Turner AA-Turner assigned Yhg1s Aug 16, 2023
@Yhg1s
Yhg1s merged commit ede9895 into python:3.12 Aug 16, 2023
@bedevere-bot bedevere-bot removed the awaiting core review label Aug 16, 2023
@zooba
zooba deleted the gh-106242-3.12 branch August 17, 2023 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@Yhg1s Yhg1s

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@zooba @ambv @Yhg1s @bedevere-bot @finnagin @serhiy-storchaka
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.