GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Revert "gh-104469 : Convert _testcapi/vectorcall_limited.c to use AC … by corona10 · Pull Request #107951 · python/cpython

Conversation

@corona10

@corona10 corona10 commented Aug 14, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

…(gh-107857)"

This reverts commit 2e27da1.

  • Issue: Improve the readability and maintainability of test_capi using the AC #104469

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
brettcannon reacted with heart emoji
All reactions
  • ❤️ 1 reaction
@corona10 corona10 self-assigned this Aug 14, 2023
@bedevere-bot bedevere-bot mentioned this pull request Aug 14, 2023
Improve the readability and maintainability of test_capi using the AC #104469
Closed
@bedevere-bot bedevere-bot added the awaiting core review label Aug 14, 2023
@corona10
Revert "pythongh-104469 : Convert _testcapi/vectorcall_limited.c to u…
95e9fb6 
…se AC (pythongh-107857)"

This reverts commit 2e27da1.
@corona10
corona10 force-pushed the gh-104469-fix branch from 26ba468 to 95e9fb6 Compare August 14, 2023 22:45
@corona10

corona10 commented Aug 14, 2023

Copy link
Copy Markdown
Member Author

cc @brettcannon @nahyeon-an
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@corona10 corona10 added skip news DO-NOT-MERGE labels Aug 14, 2023
@corona10

corona10 commented Aug 14, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

I am testing that #107953 could work -> not works
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@corona10 corona10 removed the DO-NOT-MERGE label Aug 14, 2023
@corona10
corona10 enabled auto-merge (squash) August 14, 2023 23:02
@corona10
corona10 merged commit 580f357 into python:main Aug 14, 2023
@bedevere-bot bedevere-bot removed the awaiting core review label Aug 14, 2023
iritkatriel pushed a commit to iritkatriel/cpython that referenced this pull request Aug 16, 2023
@corona10 @iritkatriel
Revert "pythongh-104469 : Convert _testcapi/vectorcall_limited.c to u…
2237015 
…se AC … (pythongh-107951)

Revert "pythongh-104469 : Convert _testcapi/vectorcall_limited.c to use AC (pythongh-107857)"

This reverts commit 2e27da1.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@corona10 corona10

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@corona10 @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.