GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-103363: Add follow_symlinks argument to `pathlib.Path.owner()` and `group()` by kamilturek · Pull Request #107962 · python/cpython

Conversation

@kamilturek

@kamilturek kamilturek commented Aug 15, 2023 •
edited by AA-Turner
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor
  • Issue: pathlib.Path.owner() and .group() should accept a follow_symlinks argument #103363

📚 Documentation preview 📚: https://cpython-previews--107962.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
kamilturek added 3 commits August 14, 2023 21:03
@kamilturek
Add follow_symlinks argument to pathlib.Path.owner() and pathlib.Path…
530f085 
….group()
@kamilturek
Update pathlib docs
5b1578c
@kamilturek
Add news entry
86a982d
@bedevere-bot bedevere-bot mentioned this pull request Aug 15, 2023
pathlib.Path.owner() and .group() should accept a follow_symlinks argument #103363
Closed
kamilturek added 2 commits August 15, 2023 08:44
@kamilturek
Update What's New
77d4d0f
@kamilturek
Use correct method in test
cebcbc0
@kamilturek kamilturek changed the title gh-103363: Add follow_symlink argument to pathlib.Path.owner() and group() gh-103363: Add follow_symlinks argument to pathlib.Path.owner() and group() Aug 15, 2023
@kamilturek
Add missing follow_symlinks in tests
7296076
@kamilturek
kamilturek marked this pull request as ready for review August 15, 2023 11:27
@kamilturek
kamilturek requested a review from barneygale as a code owner August 15, 2023 11:27
@bedevere-bot bedevere-bot added the awaiting review label Aug 15, 2023
@barneygale barneygale added the topic-pathlib label Aug 25, 2023
@AA-Turner

This comment was marked as resolved.

Sign in to view
barneygale
barneygale requested changes Nov 26, 2023
View reviewed changes

@barneygale barneygale left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry it took me ages to review. Overall looks really good, thank you. Could you merge in the latest main? You'll find there's a new _PathBase class with its own owner() and group() methods - please add the follow_symlinks argument there too. Thanks again!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Lib/test/test_pathlib.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot added awaiting changes and removed awaiting review labels Nov 26, 2023
@bedevere-app

bedevere-app Bot commented Nov 26, 2023

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
kamilturek added 4 commits December 2, 2023 10:31
@kamilturek
Move all_users and all_groups into tests
9077bc3
@kamilturek
Merge branch 'main' into pythongh-103363
5ed359d
@kamilturek
Bring kwards back
49d716e
@kamilturek
Add kwargs to _PathBase
9279158
@kamilturek

kamilturek commented Dec 2, 2023

Copy link
Copy Markdown
Contributor Author

Hey @barneygale. Thanks for the review. That's really appreciated.

I have made the requested changes; please review again
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@kamilturek
kamilturek requested a review from barneygale December 2, 2023 11:09
@kamilturek

kamilturek commented Dec 2, 2023

Copy link
Copy Markdown
Contributor Author

I have made the requested changes; please review again
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
barneygale
barneygale approved these changes Dec 4, 2023
View reviewed changes

@barneygale barneygale left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Smashing, thanks so much

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
kamilturek reacted with heart emoji
All reactions
  • ❤️ 1 reaction
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting changes labels Dec 4, 2023
@barneygale
barneygale merged commit a1551b4 into python:main Dec 4, 2023
@bedevere-app bedevere-app Bot removed the awaiting merge label Dec 4, 2023
@kamilturek
kamilturek deleted the gh-103363 branch December 4, 2023 21:14
@kamilturek
kamilturek restored the gh-103363 branch December 4, 2023 21:14
@kamilturek
kamilturek deleted the gh-103363 branch December 4, 2023 21:14
@kamilturek
kamilturek restored the gh-103363 branch December 4, 2023 21:20
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@kamilturek @aisk
pythongh-103363: Add follow_symlinks argument to `pathlib.Path.owner(…
0909269 
…)` and `group()` (python#107962)
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@kamilturek @Glyphack
pythongh-103363: Add follow_symlinks argument to `pathlib.Path.owner(…
b0c814f 
…)` and `group()` (python#107962)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@barneygale barneygale barneygale approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

topic-pathlib

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@kamilturek @AA-Turner @barneygale @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.