GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — GH-92584: Remove Installing Python Modules (Distutils version) by AA-Turner · Pull Request #108020 · python/cpython

Conversation

@AA-Turner

@AA-Turner AA-Turner commented Aug 16, 2023 •
edited by github-actions Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

This removes install/index, per the notice in the header:

The entire distutils package has been deprecated and will be removed in Python 3.12. This documentation is retained as a reference only, and will be removed with the package.

See #108018 to retain the install scheme content in the sysconfig docs.

A

  • Issue: PEP 632: Remove the distutils package (Python 3.12) #92584

📚 Documentation preview 📚: https://cpython-previews--108020.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@AA-Turner
Remove Installing Python Modules (Distutils version)
387242f
@AA-Turner AA-Turner added docs Documentation in the Doc dir skip news needs backport to 3.12 only security fixes labels Aug 16, 2023
@AA-Turner
AA-Turner requested review from vstinner and zooba August 16, 2023 13:24
@bedevere-bot bedevere-bot mentioned this pull request Aug 16, 2023
PEP 632: Remove the distutils package (Python 3.12) #92584
Closed
@bedevere-bot bedevere-bot added the awaiting review label Aug 16, 2023
@AA-Turner
Sphinx 3.2 doesn't like suppressed ref links
71416fb
@vstinner

vstinner commented Aug 16, 2023

Copy link
Copy Markdown
Member

The doc fails to build:

Doc/library/site.rst:188: WARNING: undefined label: inst-alt-install-user (if the link has no caption the label must precede a section header)
Doc/using/cmdline.rst:812: WARNING: undefined label: inst-alt-install-user (if the link has no caption the label must precede a section header)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
vstinner
vstinner approved these changes Aug 16, 2023
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Aug 16, 2023
@AA-Turner
Remove ref
a5ccf59
@AA-Turner

AA-Turner commented Aug 16, 2023

Copy link
Copy Markdown
Member Author

@vstinner thanks, I've removed the references so the build succeeds, #108018 will restore them.

A
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
vstinner
vstinner reviewed Aug 16, 2023
View reviewed changes
Comment thread Doc/using/cmdline.rst Outdated
Defines the :data:`user base directory <site.USER_BASE>`, which is used to
compute the path of the :data:`user site-packages directory <site.USER_SITE>`
and :ref:`Distutils installation paths <inst-alt-install-user>` for
and Distutils installation paths for

@vstinner vstinner Aug 16, 2023

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it really useful to keep a reference to removed Distutils? setup.py is legacy, no?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@AA-Turner AA-Turner Aug 16, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#108040 removes the reference to Distutils & replaces setup.py with pip, I wanted to keep each PR distinct. When the first one is merged I'll resolve the conflicts.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@AA-Turner AA-Turner Aug 16, 2023

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conflicts resolved.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@AA-Turner
Merge branch 'main' into drop-install
df3ce4f 
# Conflicts:
#	Doc/using/cmdline.rst
@vstinner

vstinner commented Aug 16, 2023

Copy link
Copy Markdown
Member

A Docs job failed:

Doc/using/cmdline.rst:812: WARNING: undefined label: inst-alt-install-user (if the link has no caption the label must precede a section header)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@AA-Turner
Remove ref
d52d847
@AA-Turner

AA-Turner commented Aug 16, 2023

Copy link
Copy Markdown
Member Author

A Docs job failed:

Oh, I messed up the merge. Pushed a fix.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner
vstinner enabled auto-merge (squash) August 16, 2023 21:03
@vstinner
vstinner merged commit fbb7cbc into python:main Aug 16, 2023
@miss-islington

miss-islington commented Aug 16, 2023

Copy link
Copy Markdown
Contributor

Thanks @AA-Turner for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting merge label Aug 16, 2023
@miss-islington

miss-islington commented Aug 16, 2023

Copy link
Copy Markdown
Contributor

Sorry, @AA-Turner and @vstinner, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker fbb7cbc0e92168077fd56de942901511e99ca60a 3.12
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington miss-islington assigned vstinner Aug 16, 2023
@bedevere-bot

bedevere-bot commented Aug 16, 2023

Copy link
Copy Markdown

GH-108062 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.12 only security fixes label Aug 16, 2023
AA-Turner added a commit to AA-Turner/cpython that referenced this pull request Aug 16, 2023
@AA-Turner
[3.12] pythonGH-92584: Remove Installing Python Modules (Distutils ve…
67df3e3 
…rsion) (pythonGH-108020).

(cherry picked from commit fbb7cbc)

Co-authored-by: Adam Turner <[email protected]>
Yhg1s pushed a commit that referenced this pull request Aug 17, 2023
@AA-Turner
[3.12] GH-92584: Remove Installing Python Modules (Distutils version) (…
560e859 
…GH-108020) (#108062)

* [3.12] GH-92584: Remove Installing Python Modules (Distutils version) (GH-108020).
(cherry picked from commit fbb7cbc)

Co-authored-by: Adam Turner <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes
@zooba zooba Awaiting requested review from zooba

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@vstinner vstinner

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@AA-Turner @vstinner @miss-islington @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.