GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — gh-107298: Fix C API datetime documentation by serhiy-storchaka · Pull Request #108034 · python/cpython

Conversation

serhiy-storchaka commented Aug 16, 2023 •

edited by github-actions Bot

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Member

Issue: Fix Sphinx warnings in the C API documentation #107298

📚 Documentation preview 📚: https://cpython-previews--108034.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

serhiy-storchaka added docs

Documentation in the Doc dir

skip news needs backport to 3.11

only security fixes

needs backport to 3.12 only security fixes labels

Aug 16, 2023

serhiy-storchaka requested review from abalkin and pganssle as code owners

August 16, 2023 15:38

bedevere-bot mentioned this pull request

Aug 16, 2023

Fix Sphinx warnings in the C API documentation #107298

Closed

bedevere-bot added the awaiting core review label

Aug 16, 2023


          pythongh-107298: Fix C API datetime documentation

85ea2fc

serhiy-storchaka force-pushed the docs-capi-datetime branch from 01185f1 to 85ea2fc Compare

August 16, 2023 15:51

serhiy-storchaka requested a review from vstinner

August 21, 2023 10:49

vstinner reviewed

Aug 21, 2023

View reviewed changes

Comment thread

Doc/c-api/datetime.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

Comment thread

Doc/c-api/datetime.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.

vstinner approved these changes

Aug 21, 2023

View reviewed changes

vstinner left a comment

Copy link

Copy Markdown

Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Feel free to ignore my remarks (or address them in a separated PR).

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions

bedevere-bot added awaiting merge and removed awaiting core review labels

Aug 21, 2023

serhiy-storchaka added 2 commits

August 21, 2023 20:31


          Fix signatures of PyTimeZone_FromOffset() and PyTimeZone_FromOffsetAn…

df665fd

…dName().


          Merge branch 'main' into docs-capi-datetime

960649b

serhiy-storchaka merged commit d63972e into python:main

Aug 21, 2023

serhiy-storchaka deleted the docs-capi-datetime branch

August 21, 2023 18:15

miss-islington commented Aug 21, 2023

Copy link

Copy Markdown

Contributor

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot added awaiting core review and removed awaiting merge labels

Aug 21, 2023

bedevere-bot commented Aug 21, 2023

Copy link

Copy Markdown

There's a new commit after the PR has been approved.

@vstinner: please review the changes made to this pull request.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

miss-islington commented Aug 21, 2023

Copy link

Copy Markdown

Contributor

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker d63972e289e05b0d82e59f32f107312a8b3de7b5 3.12

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot requested a review from vstinner

August 21, 2023 18:16

miss-islington assigned serhiy-storchaka

Aug 21, 2023

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Aug 21, 2023


          pythongh-107298: Fix C API datetime documentation (pythonGH-108034)

bf6afa1

(cherry picked from commit d63972e)

Co-authored-by: Serhiy Storchaka <[email protected]>

bedevere-bot commented Aug 21, 2023

Copy link

Copy Markdown

GH-108233 is a backport of this pull request to the 3.11 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot removed the needs backport to 3.11 only security fixes label

Aug 21, 2023

serhiy-storchaka commented Aug 21, 2023

Copy link

Copy Markdown

Member Author

Thank you for your review @vstinner.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request

Aug 21, 2023


          [3.12] pythongh-107298: Fix C API datetime documentation (pythonGH-10…

a14f0a1

…8034).

(cherry picked from commit d63972e)

Co-authored-by: Serhiy Storchaka <[email protected]>

bedevere-bot commented Aug 21, 2023

Copy link

Copy Markdown

GH-108234 is a backport of this pull request to the 3.12 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot removed the needs backport to 3.12 only security fixes label

Aug 21, 2023

Yhg1s pushed a commit that referenced this pull request

Aug 21, 2023


          [3.12] gh-107298: Fix C API datetime documentation (GH-108034). (#108234

47f60c3

)

(cherry picked from commit d63972e)

ambv pushed a commit that referenced this pull request

Aug 22, 2023


          [3.11] gh-107298: Fix C API datetime documentation (GH-108034) (#108233)

80c7ae0

(cherry picked from commit d63972e)

Co-authored-by: Serhiy Storchaka <[email protected]>

serhiy-storchaka removed their assignment

Sep 8, 2023

Reviewers

pganssle

Awaiting requested review from pganssle

pganssle is a code owner

abalkin

Awaiting requested review from abalkin

vstinner

Awaiting requested review from vstinner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting core review docs

Documentation in the Doc dir

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

serhiy-storchaka commented Aug 16, 2023 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

vstinner left a comment

Choose a reason for hiding this comment

Uh oh!

miss-islington commented Aug 21, 2023

Uh oh!

bedevere-bot commented Aug 21, 2023

Uh oh!

miss-islington commented Aug 21, 2023

Uh oh!

bedevere-bot commented Aug 21, 2023

Uh oh!

serhiy-storchaka commented Aug 21, 2023

Uh oh!

bedevere-bot commented Aug 21, 2023

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

serhiy-storchaka commented Aug 16, 2023 •

edited by github-actions Bot

Loading

Uh oh!

There was an error while loading. Please reload this page.