GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — GH-92584: Remove references to Distutils in configure.rst by AA-Turner · Pull Request #108043 · python/cpython

Conversation

@AA-Turner

@AA-Turner AA-Turner commented Aug 16, 2023 •
edited by github-actions Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

setup.py was removed in #94474.

  • Issue: PEP 632: Remove the distutils package (Python 3.12) #92584

📚 Documentation preview 📚: https://cpython-previews--108043.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@AA-Turner
Remove references to Distutils in configure.rst
4806813
@AA-Turner AA-Turner added docs Documentation in the Doc dir skip news needs backport to 3.12 only security fixes labels Aug 16, 2023
@AA-Turner
AA-Turner requested a review from vstinner August 16, 2023 16:51
@AA-Turner
AA-Turner requested review from corona10 and erlend-aasland as code owners August 16, 2023 16:51
@bedevere-bot bedevere-bot mentioned this pull request Aug 16, 2023
PEP 632: Remove the distutils package (Python 3.12) #92584
Closed
@bedevere-bot bedevere-bot added the awaiting review label Aug 16, 2023
AA-Turner
AA-Turner commented Aug 16, 2023
View reviewed changes
Comment thread Doc/using/configure.rst
Comment on lines 781 to 783
Both :envvar:`CPPFLAGS` and :envvar:`LDFLAGS` need to contain the shell's
value for setup.py to be able to build extension modules using the
value to be able to build extension modules using the
directories specified in the environment variables.

@AA-Turner AA-Turner Aug 16, 2023

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've just removed setup.py rather than replacing with e.g. Makefile as I believe CPPFLAGS and LDFLAGS are used by the windows build, though I'm not sure.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Doc/using/configure.rst
Comment on lines +819 to +820
extensions. Use it when a compiler flag should *not* be part of
:envvar:`CFLAGS` once Python is installed (:gh:`65320`).

@AA-Turner AA-Turner Aug 16, 2023

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if the issue link (#65320) is still relevant, but I've kept in case.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner
vstinner merged commit e88eb37 into python:main Aug 16, 2023
@miss-islington

miss-islington commented Aug 16, 2023

Copy link
Copy Markdown
Contributor

Thanks @AA-Turner for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting review label Aug 16, 2023
@vstinner

vstinner commented Aug 16, 2023

Copy link
Copy Markdown
Member

Merged, thanks.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot

bedevere-bot commented Aug 16, 2023

Copy link
Copy Markdown

GH-108063 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 16, 2023
@AA-Turner @miss-islington
pythonGH-92584: Remove references to Distutils in configure.rst (pyth…
2071059 
…onGH-108043)

Remove references to Distutils in configure.rst
(cherry picked from commit e88eb37)

Co-authored-by: Adam Turner <[email protected]>
@bedevere-bot bedevere-bot removed the needs backport to 3.12 only security fixes label Aug 16, 2023
Yhg1s pushed a commit that referenced this pull request Aug 16, 2023
@miss-islington @AA-Turner
[3.12] GH-92584: Remove references to Distutils in configure.rst (GH-…
931df0a 
…108043) (#108063)

GH-92584: Remove references to Distutils in configure.rst (GH-108043)

Remove references to Distutils in configure.rst
(cherry picked from commit e88eb37)

Co-authored-by: Adam Turner <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner Awaiting requested review from vstinner
@erlend-aasland erlend-aasland Awaiting requested review from erlend-aasland erlend-aasland is a code owner
@corona10 corona10 Awaiting requested review from corona10 corona10 is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@AA-Turner @miss-islington @vstinner @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.