GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.12] gh-91051: fix type watcher test to be robust to existing watcher (GH-107989) by miss-islington · Pull Request #108053 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented Aug 16, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

(cherry picked from commit fce93c8)

Co-authored-by: Carl Meyer [email protected]

  • Issue: Allow extensions to set a callback to be invoked when a type is modified #91051

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@carljm @miss-islington
pythongh-91051: fix type watcher test to be robust to existing watcher (
f785150 
pythonGH-107989)

(cherry picked from commit fce93c8)

Co-authored-by: Carl Meyer <[email protected]>
@bedevere-bot bedevere-bot mentioned this pull request Aug 16, 2023
Allow extensions to set a callback to be invoked when a type is modified #91051
Closed
@bedevere-bot bedevere-bot added the skip news label Aug 16, 2023
@bedevere-bot bedevere-bot mentioned this pull request Aug 16, 2023
gh-91051: fix type watcher test to be robust to existing watcher #107989
Merged
@bedevere-bot bedevere-bot added awaiting review tests Tests in the Lib/test dir labels Aug 16, 2023
@carljm carljm assigned Yhg1s Aug 16, 2023
@carljm

carljm commented Aug 16, 2023

Copy link
Copy Markdown
Member

@Yhg1s here's one last PR to make watcher tests robust to an already-installed watcher, if you want to get it into 3.12.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Yhg1s
Yhg1s merged commit 84a4370 into python:3.12 Aug 16, 2023
@bedevere-bot bedevere-bot removed the awaiting review label Aug 16, 2023
@miss-islington
miss-islington deleted the backport-fce93c8-3.12 branch August 16, 2023 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@Yhg1s Yhg1s

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@miss-islington @carljm @Yhg1s @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.