GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-91051: fix type watcher test to be robust to existing watcher by carljm · Pull Request #107989 · python/cpython

Conversation

@carljm

@carljm carljm commented Aug 16, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

One more case of a watcher test spuriously failing because a watcher is already installed. I think this should be the last one.

  • Issue: Allow extensions to set a callback to be invoked when a type is modified #91051

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@carljm
pythongh-91051: fix type watcher test to be robust to existing watcher
8c38bd5
@carljm
carljm requested a review from itamaro August 16, 2023 00:30
@bedevere-bot bedevere-bot mentioned this pull request Aug 16, 2023
Allow extensions to set a callback to be invoked when a type is modified #91051
Closed
@bedevere-bot bedevere-bot added awaiting core review tests Tests in the Lib/test dir labels Aug 16, 2023
@carljm carljm added skip news needs backport to 3.12 only security fixes labels Aug 16, 2023
itamaro
itamaro approved these changes Aug 16, 2023
View reviewed changes
Comment thread Lib/test/test_capi/test_watchers.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@carljm
avoid while True
b1b0193
@carljm
carljm merged commit fce93c8 into python:main Aug 16, 2023
@miss-islington

miss-islington commented Aug 16, 2023

Copy link
Copy Markdown
Contributor

Thanks @carljm for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting core review label Aug 16, 2023
@carljm
carljm deleted the typewatchertest branch August 16, 2023 19:13
@bedevere-bot

bedevere-bot commented Aug 16, 2023

Copy link
Copy Markdown

GH-108053 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.12 only security fixes label Aug 16, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 16, 2023
@carljm @miss-islington
pythongh-91051: fix type watcher test to be robust to existing watcher (
f785150 
pythonGH-107989)

(cherry picked from commit fce93c8)

Co-authored-by: Carl Meyer <[email protected]>
Yhg1s pushed a commit that referenced this pull request Aug 16, 2023
@miss-islington @carljm
[3.12] gh-91051: fix type watcher test to be robust to existing watch…
84a4370 
…er (GH-107989) (#108053)

gh-91051: fix type watcher test to be robust to existing watcher (GH-107989)
(cherry picked from commit fce93c8)

Co-authored-by: Carl Meyer <[email protected]>
facebook-github-bot pushed a commit to facebookincubator/MetaPython that referenced this pull request Aug 17, 2023
Carl Meyer @facebook-github-bot
use type watchers in JIT and shadowcode
730e0e7 
Summary:
Use type watchers instead of direct calls for handling type modifications in JIT and shadowcode.

Also backport python/cpython#107989 so the type watchers tests are resilient to there already being a type watcher installed.

Reviewed By: alexmalyshev

Differential Revision: D48340200

fbshipit-source-id: 25798b824bc231bd68f8ec7c4c81bb2fa84e3914
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@itamaro itamaro itamaro approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@carljm @miss-islington @bedevere-bot @itamaro
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.