GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Resolve reference warnings in faq/gui.rst by AA-Turner · Pull Request #108147 · python/cpython

Conversation

@AA-Turner

@AA-Turner AA-Turner commented Aug 19, 2023 •
edited by github-actions Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

📚 Documentation preview 📚: https://cpython-previews--108147.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@AA-Turner
Resolve reference warnings in faq/gui.rst
8b46599
@AA-Turner AA-Turner added docs Documentation in the Doc dir skip issue skip news needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Aug 19, 2023
@AA-Turner
AA-Turner requested review from erlend-aasland and hugovk August 19, 2023 18:45
@bedevere-bot bedevere-bot added the awaiting review label Aug 19, 2023
@AA-Turner
fixup! Resolve reference warnings in faq/gui.rst
e6dea23
erlend-aasland
erlend-aasland reviewed Aug 20, 2023
View reviewed changes
Comment thread Doc/faq/gui.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@AA-Turner
Reference the tkinter documentation
421a415
erlend-aasland
erlend-aasland approved these changes Aug 21, 2023
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Aug 21, 2023
hugovk
hugovk approved these changes Aug 21, 2023
View reviewed changes

@hugovk hugovk left a comment •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, all Doc/faq/ warnings now fixed!

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@hugovk
Merge branch 'main' into refwarn/faq-gui
e739e8c
@hugovk
hugovk enabled auto-merge (squash) August 21, 2023 07:25
@hugovk
hugovk merged commit 8f3d09b into python:main Aug 21, 2023
@miss-islington

miss-islington commented Aug 21, 2023

Copy link
Copy Markdown
Contributor

Thanks @AA-Turner for the PR, and @hugovk for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting merge label Aug 21, 2023
@bedevere-bot

bedevere-bot commented Aug 21, 2023

Copy link
Copy Markdown

GH-108193 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot

bedevere-bot commented Aug 21, 2023

Copy link
Copy Markdown

GH-108194 is a backport of this pull request to the 3.11 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed needs backport to 3.12 only security fixes needs backport to 3.11 only security fixes labels Aug 21, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 21, 2023
@AA-Turner @hugovk @miss-islington
Resolve reference warnings in faq/gui.rst (pythonGH-108147)
7c64eb3 
(cherry picked from commit 8f3d09b)

Co-authored-by: Adam Turner <[email protected]>
Co-authored-by: Hugo van Kemenade <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 21, 2023
@AA-Turner @hugovk @miss-islington
Resolve reference warnings in faq/gui.rst (pythonGH-108147)
d54deb7 
(cherry picked from commit 8f3d09b)

Co-authored-by: Adam Turner <[email protected]>
Co-authored-by: Hugo van Kemenade <[email protected]>
ambv pushed a commit that referenced this pull request Aug 22, 2023
@miss-islington @AA-Turner @hugovk
[3.11] Resolve reference warnings in faq/gui.rst (GH-108147) (#108194)
3a39e15 
(cherry picked from commit 8f3d09b)

Co-authored-by: Adam Turner <[email protected]>
Co-authored-by: Hugo van Kemenade <[email protected]>
Yhg1s pushed a commit that referenced this pull request Sep 4, 2023
@miss-islington @AA-Turner @hugovk
[3.12] Resolve reference warnings in faq/gui.rst (GH-108147) (#108193)
331b026 
* Resolve reference warnings in faq/gui.rst (GH-108147)
(cherry picked from commit 8f3d09b)

Co-authored-by: Adam Turner <[email protected]>
Co-authored-by: Hugo van Kemenade <[email protected]>

* Resolve reference warnings in faq/gui.rst

---------

Co-authored-by: Adam Turner <[email protected]>
Co-authored-by: Hugo van Kemenade <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hugovk hugovk hugovk approved these changes
@erlend-aasland erlend-aasland erlend-aasland approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@AA-Turner @miss-islington @bedevere-bot @hugovk @erlend-aasland
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.