GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-107526: Fix test_module_level_callable_unrepresentable_default by corona10 · Pull Request #108187 · python/cpython

Conversation

@corona10

@corona10 corona10 commented Aug 21, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: Help text of builtin functions – missing signatures #107526

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
xncbf reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@corona10
no-issue: Fix test_module_level_callable_unrepresentable_default
33aea8b
@bedevere-bot bedevere-bot added tests Tests in the Lib/test dir awaiting core review labels Aug 21, 2023
@corona10 corona10 changed the title no-issue: Fix test_module_level_callable_unrepresentable_default gh-107526: Fix test_module_level_callable_unrepresentable_default Aug 21, 2023
@bedevere-bot bedevere-bot mentioned this pull request Aug 9, 2023
Help text of builtin functions – missing signatures #107526
Closed
@corona10
corona10 requested a review from sobolevn August 21, 2023 03:47
@corona10 corona10 added the skip news label Aug 21, 2023
@corona10
corona10 requested a review from JelleZijlstra August 21, 2023 03:48
JelleZijlstra
JelleZijlstra approved these changes Aug 21, 2023
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Aug 21, 2023
@corona10
corona10 enabled auto-merge (squash) August 21, 2023 03:59
xncbf
xncbf approved these changes Aug 21, 2023
View reviewed changes
@xncbf xncbf mentioned this pull request Aug 21, 2023
gh-107526: Revert "gh-100357: Convert several functions in bltinsmodule to AC" #107542
Merged
@corona10
corona10 merged commit 04f7875 into python:main Aug 21, 2023
@bedevere-bot bedevere-bot removed the awaiting merge label Aug 21, 2023
@serhiy-storchaka

serhiy-storchaka commented Aug 21, 2023

Copy link
Copy Markdown
Member

It is not a proper fix. The purpose of the test not testing the signature of getattr(), but testing how pydoc handles such kind of signatures.

I'll write a proper fix.
xncbf reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@corona10
corona10 deleted the fix-pydoc branch August 21, 2023 05:01
@serhiy-storchaka

serhiy-storchaka commented Sep 12, 2023

Copy link
Copy Markdown
Member

#109325 makes these tests more reliable.
xncbf reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes
@sobolevn sobolevn Awaiting requested review from sobolevn
+1 more reviewer
@xncbf xncbf xncbf approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@corona10 @serhiy-storchaka @JelleZijlstra @xncbf @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.