GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-107526: Revert "gh-100357: Convert several functions in bltinsmodule to AC" by sobolevn · Pull Request #107542 · python/cpython

Conversation

@sobolevn

@sobolevn sobolevn commented Aug 1, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: Help text of builtin functions – missing signatures #107526

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@sobolevn
pythongh-107526: Revert "pythongh-100357: Convert several functions i…
db35ad9 
…n bltinsmodule to AC"
@bedevere-bot bedevere-bot mentioned this pull request Aug 1, 2023
Help text of builtin functions – missing signatures #107526
Closed
@bedevere-bot bedevere-bot added the awaiting review label Aug 1, 2023
@sobolevn
Run make clinic
9aa7e57
JelleZijlstra
JelleZijlstra reviewed Aug 1, 2023
View reviewed changes
Comment thread Python/bltinmodule.c Outdated
if (!PyArg_UnpackTuple(args, "vars", 0, 1, &v))
return NULL;
if (v == NULL) {
d = Py_XNewRef(PyEval_GetLocals());

@JelleZijlstra JelleZijlstra Aug 1, 2023

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should use _PyEval_GetFrameLocals (I think that's what's causing the test failures; maybe there's similar issues in dir() and locals()).

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@sobolevn sobolevn Aug 9, 2023

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I've missed it.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
sobolevn added 4 commits August 9, 2023 14:54
@sobolevn
Merge branch 'main' into issue-107526
00b6540
@sobolevn
Address review
e1b491b
@sobolevn
Remove NEWS entry
a7a41ce
@sobolevn
Add NEWS entry about revert
b8371ac
@sobolevn
sobolevn requested a review from JelleZijlstra August 17, 2023 07:18
JelleZijlstra
JelleZijlstra approved these changes Aug 21, 2023
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Aug 21, 2023
@JelleZijlstra JelleZijlstra added the needs backport to 3.12 only security fixes label Aug 21, 2023
@JelleZijlstra
JelleZijlstra merged commit db6dc6c into python:main Aug 21, 2023
@miss-islington

miss-islington commented Aug 21, 2023

Copy link
Copy Markdown
Contributor

Thanks @sobolevn for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting merge label Aug 21, 2023
@miss-islington

miss-islington commented Aug 21, 2023

Copy link
Copy Markdown
Contributor

Sorry, @sobolevn and @JelleZijlstra, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker db6dc6ce41f42ec2cb4fdfbc0a099114f42e888f 3.12
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington miss-islington assigned JelleZijlstra Aug 21, 2023
@JelleZijlstra

JelleZijlstra commented Aug 21, 2023

Copy link
Copy Markdown
Member

@sobolevn could you make a 3.12 backport?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@xncbf

xncbf commented Aug 21, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

It seems that the workflow is broken starting from this PR.
https://github.com/python/cpython/actions/workflows/build.yml

He's working here! ignore it #108187
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@hugovk

hugovk commented Feb 20, 2025

Copy link
Copy Markdown
Member

Triage: Is the 3.12 backport still needed? If not, let's remove the label.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@sobolevn

sobolevn commented Feb 20, 2025

Copy link
Copy Markdown
Member Author

Yes, 3.12 backport is still needed. Working on it.
hugovk reacted with rocket emoji
All reactions
  • 🚀 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
sobolevn added a commit to sobolevn/cpython that referenced this pull request Feb 20, 2025
@sobolevn
[3.12] pythongh-107526: Revert "pythongh-100357: Convert several func…
54efeaf 
…tions in bltinsmodule to AC" (pythonGH-107542)
@bedevere-app

bedevere-app Bot commented Feb 20, 2025

Copy link
Copy Markdown

GH-130371 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.12 only security fixes label Feb 20, 2025
sobolevn added a commit that referenced this pull request Feb 26, 2025
@sobolevn
[3.12] gh-107526: Revert "gh-100357: Convert several functions in blt…
f841099 
…insmodule to AC" (GH-107542) (#130371)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@JelleZijlstra JelleZijlstra

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@sobolevn @miss-islington @JelleZijlstra @xncbf @hugovk @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.