GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-108303: Move `ann_module*.py` files to `typinganndata/` folder by sobolevn · Pull Request #108354 · python/cpython

Conversation

@sobolevn

@sobolevn sobolevn commented Aug 23, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Couple of thoughts:

  1. This is an internal change for sure
  2. These files were bothering me for quite some time
  3. This can create merge conflicts that can be probably be solved automatically
  4. This should be backported so we have the same test structure

CC @vstinner

  • Issue: Move test files into test subdirectories #108303

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@sobolevn
pythongh-108303: Move ann_module*.py files to typinganndata/ folder
7500a99
@sobolevn
sobolevn requested review from AlexWaygood, Fidget-Spinner, JelleZijlstra and gvanrossum as code owners August 23, 2023 06:33
@bedevere-bot bedevere-bot mentioned this pull request Aug 22, 2023
Move test files into test subdirectories #108303
Closed
@bedevere-bot bedevere-bot added the awaiting review label Aug 23, 2023
@sobolevn sobolevn added the skip news label Aug 23, 2023
@vstinner
vstinner merged commit 3f61cf6 into python:main Aug 23, 2023
@vstinner

vstinner commented Aug 23, 2023

Copy link
Copy Markdown
Member

Merged, thanks.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting review label Aug 23, 2023
@sobolevn sobolevn mentioned this pull request Sep 12, 2023
gh-108303: Move tokenize-related data to Lib/test/tokenizedata #109265
Merged
@vstinner vstinner added the needs backport to 3.12 only security fixes label Sep 21, 2023
@miss-islington

miss-islington commented Sep 21, 2023

Copy link
Copy Markdown
Contributor

Thanks @sobolevn for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 21, 2023
@sobolevn @miss-islington
pythongh-108303: Move ann_module*.py files to typinganndata/ fold…
86a4f67 
…er (pythonGH-108354)

(cherry picked from commit 3f61cf6)

Co-authored-by: Nikita Sobolev <[email protected]>
@bedevere-app

bedevere-app Bot commented Sep 21, 2023

Copy link
Copy Markdown

GH-109672 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.12 only security fixes label Sep 21, 2023
@vstinner vstinner added the needs backport to 3.11 only security fixes label Sep 21, 2023
@miss-islington

miss-islington commented Sep 21, 2023

Copy link
Copy Markdown
Contributor

Thanks @sobolevn for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington

miss-islington commented Sep 21, 2023

Copy link
Copy Markdown
Contributor

Sorry, @sobolevn and @vstinner, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 3f61cf646d0506baa0c0c2118f05110446519c62 3.11
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@miss-islington miss-islington assigned vstinner Sep 21, 2023
vstinner pushed a commit to vstinner/cpython that referenced this pull request Sep 21, 2023
@sobolevn @vstinner
pythongh-108303: Move ann_module*.py files to typinganndata/ fold…
7ca3fc6 
…er (python#108354)

(cherry picked from commit 3f61cf6)
@bedevere-app

bedevere-app Bot commented Sep 21, 2023

Copy link
Copy Markdown

GH-109673 is a backport of this pull request to the 3.11 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.11 only security fixes label Sep 21, 2023
vstinner added a commit that referenced this pull request Sep 21, 2023
@vstinner @sobolevn
[3.11] gh-108303: Move ann_module*.py files to typinganndata/ fol…
e59ee6c 
…der (#108354) (#109673)

gh-108303: Move `ann_module*.py` files to `typinganndata/` folder (#108354)

(cherry picked from commit 3f61cf6)

Co-authored-by: Nikita Sobolev <[email protected]>
Yhg1s pushed a commit that referenced this pull request Oct 2, 2023
@miss-islington @sobolevn
[3.12] gh-108303: Move ann_module*.py files to typinganndata/ fol…
b153cab 
…der (GH-108354) (#109672)

gh-108303: Move `ann_module*.py` files to `typinganndata/` folder (GH-108354)
(cherry picked from commit 3f61cf6)

Co-authored-by: Nikita Sobolev <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gvanrossum gvanrossum Awaiting requested review from gvanrossum
@Fidget-Spinner Fidget-Spinner Awaiting requested review from Fidget-Spinner
@JelleZijlstra JelleZijlstra Awaiting requested review from JelleZijlstra JelleZijlstra is a code owner
@AlexWaygood AlexWaygood Awaiting requested review from AlexWaygood AlexWaygood is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@vstinner vstinner

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@sobolevn @vstinner @miss-islington @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.