GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-107902: Don't test setting suid/sgid on systems that don't support them by encukou · Pull Request #108368 · python/cpython

Conversation

@encukou

@encukou encukou commented Aug 23, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: test_tarfile fails on file modes #107902

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@encukou
pythongh-107902: Don't test setting suid/sgid on systems that don't s…
b26a475 
…upport them
@encukou
encukou requested a review from furkanonder August 23, 2023 14:40
@encukou
encukou requested a review from ethanfurman as a code owner August 23, 2023 14:40
@bedevere-bot bedevere-bot mentioned this pull request Aug 12, 2023
test_tarfile fails on file modes #107902
Closed
2 tasks done
@bedevere-bot bedevere-bot added tests Tests in the Lib/test dir awaiting core review labels Aug 23, 2023
@encukou encukou added the skip news label Aug 23, 2023
@encukou

encukou commented Aug 23, 2023

Copy link
Copy Markdown
Member Author

@furkanonder, could you check this on the Manjaro aarch64 system?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
ethanfurman
ethanfurman reviewed Aug 23, 2023
View reviewed changes
Comment thread Lib/test/test_tarfile.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@encukou
Test suid bit on directories
316b32b
@furkanonder

furkanonder commented Aug 24, 2023

Copy link
Copy Markdown
Contributor

@furkanonder, could you check this on the Manjaro aarch64 system?

It looks good to me, the tests are not failing anymore.

[ted@rasp4 cpython]$ ./python -m test test_tarfile
0:00:00 load avg: 1.04 Run tests sequentially
0:00:00 load avg: 1.04 [1/1] test_tarfile
test_tarfile passed in 2 min 29 sec

== Tests result: SUCCESS ==

1 test OK.

Total duration: 2 min 29 sec
Tests result: SUCCESS
[ted@rasp4 cpython]$
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
furkanonder
furkanonder approved these changes Aug 24, 2023
View reviewed changes
@encukou
encukou merged commit 40e52c9 into python:main Sep 4, 2023
@bedevere-bot bedevere-bot removed the awaiting core review label Sep 4, 2023
@encukou
encukou deleted the gh-107902 branch September 4, 2023 13:46
encukou added a commit to encukou/cpython that referenced this pull request Oct 10, 2024
@encukou
pythongh-107902: Don't test setting suid/sgid on systems that don't s…
e3ecd5b 
…upport them (pythonGH-108368)
@encukou encukou mentioned this pull request Oct 10, 2024
[3.10] gh-107902: gh-108948: Don't test setting suid/sgid/sticky on systems that don't support them (GH-108368) (GH-109697) #125255
Merged
encukou added a commit to encukou/cpython that referenced this pull request Oct 16, 2024
@encukou
pythongh-107902: Don't test setting suid/sgid on systems that don't s…
5a5b9b9 
…upport them (pythonGH-108368)
@encukou encukou mentioned this pull request Oct 16, 2024
[3.9] gh-107902: gh-108948: Don't test setting suid/sgid/sticky on systems that don't support them (GH-108368) (GH-109697) #125576
Merged
pablogsal pushed a commit that referenced this pull request Oct 22, 2024
@encukou @vstinner
[3.10] gh-107902: gh-108948: Don't test setting suid/sgid/sticky on s…
6bbaab8 
…ystems that don't support them (GH-108368) (GH-109697) (#125255)

* gh-107902: Don't test setting suid/sgid on systems that don't support them (GH-108368)

* gh-108948: Skip test_tarfile.test_modes() on EFTYPE error (#109697)

On FreeBSD, regular users cannot set the sticky bit. Skip the test if
chmod() fails with EFTYPE error.

---------

Co-authored-by: Victor Stinner <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 22, 2024
@encukou @vstinner @miss-islington
[3.10] pythongh-107902: pythongh-108948: Don't test setting suid/sgid…
3c00a44 
…/sticky on systems that don't support them (pythonGH-108368) (pythonGH-109697) (pythonGH-125255)

* pythongh-107902: Don't test setting suid/sgid on systems that don't support them (pythonGH-108368)

* pythongh-108948: Skip test_tarfile.test_modes() on EFTYPE error (pythonGH-109697)

On FreeBSD, regular users cannot set the sticky bit. Skip the test if
chmod() fails with EFTYPE error.

---------

(cherry picked from commit 6bbaab8)

Co-authored-by: Petr Viktorin <[email protected]>
Co-authored-by: Victor Stinner <[email protected]>
@miss-islington miss-islington mentioned this pull request Oct 22, 2024
[3.9] [3.10] gh-107902: gh-108948: Don't test setting suid/sgid/sticky on systems that don't support them (GH-108368) (GH-109697) (GH-125255) #125835
Closed
ambv pushed a commit that referenced this pull request Oct 28, 2024
@encukou @vstinner
[3.9] gh-107902: gh-108948: Don't test setting suid/sgid/sticky on sy…
eb16397 
…stems that don't support them (GH-108368) (GH-109697) (#125576)

On FreeBSD, regular users cannot set the sticky bit. Skip the test if
chmod() fails with EFTYPE error.

Co-authored-by: Victor Stinner <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ethanfurman ethanfurman ethanfurman left review comments
@furkanonder furkanonder furkanonder approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@encukou @furkanonder @ethanfurman @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.