GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.12] gh-108314: PyDict_GetItemString() mentions UTF-8 by vstinner · Pull Request #108448 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented Aug 24, 2023 •
edited by github-actions Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

PyDict_GetItemString(), PyDict_SetItemString() and PyDict_DelItemString() expects a UTF-8 encoding string for the key.

  • Issue: [C API] Add PyDict_ContainsString() function #108314

📚 Documentation preview 📚: https://cpython-previews--108448.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner
pythongh-108314: PyDict_GetItemString() mentions UTF-8
2164d65 
PyDict_GetItemString(), PyDict_SetItemString() and
PyDict_DelItemString() expects a UTF-8 encoding string for the key.
@vstinner vstinner added docs Documentation in the Doc dir skip news needs backport to 3.11 only security fixes labels Aug 24, 2023
@bedevere-bot bedevere-bot mentioned this pull request Aug 23, 2023
[C API] Add PyDict_ContainsString() function #108314
Closed
@bedevere-bot bedevere-bot added the awaiting core review label Aug 24, 2023
@vstinner vstinner changed the title gh-108314: PyDict_GetItemString() mentions UTF-8 [3.12] gh-108314: PyDict_GetItemString() mentions UTF-8 Aug 24, 2023
@vstinner vstinner mentioned this pull request Aug 24, 2023
gh-108314: Add PyDict_ContainsString() function #108323
Merged
@vstinner

vstinner commented Aug 24, 2023

Copy link
Copy Markdown
Member Author

cc @serhiy-storchaka
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner

vstinner commented Aug 24, 2023

Copy link
Copy Markdown
Member Author

cc @methane
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
serhiy-storchaka
serhiy-storchaka approved these changes Aug 24, 2023
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Aug 24, 2023
@Yhg1s
Yhg1s merged commit 9a225d7 into python:3.12 Aug 25, 2023
@miss-islington

miss-islington commented Aug 25, 2023

Copy link
Copy Markdown
Contributor

Thanks @vstinner for the PR, and @Yhg1s for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the awaiting merge label Aug 25, 2023
@bedevere-bot

bedevere-bot commented Aug 25, 2023

Copy link
Copy Markdown

GH-108489 is a backport of this pull request to the 3.11 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Aug 25, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 25, 2023
@vstinner @miss-islington
[3.12] pythongh-108314: PyDict_GetItemString() mentions UTF-8 (python…
9609601 
…GH-108448)

pythongh-108314: PyDict_GetItemString() mentions UTF-8

PyDict_GetItemString(), PyDict_SetItemString() and
PyDict_DelItemString() expects a UTF-8 encoding string for the key.
(cherry picked from commit 9a225d7)

Co-authored-by: Victor Stinner <[email protected]>
vstinner added a commit that referenced this pull request Aug 25, 2023
@miss-islington @vstinner
[3.11] [3.12] gh-108314: PyDict_GetItemString() mentions UTF-8 (GH-10…
cc81f5b 
…8448) (#108489)

[3.12] gh-108314: PyDict_GetItemString() mentions UTF-8 (GH-108448)

gh-108314: PyDict_GetItemString() mentions UTF-8

PyDict_GetItemString(), PyDict_SetItemString() and
PyDict_DelItemString() expects a UTF-8 encoding string for the key.
(cherry picked from commit 9a225d7)

Co-authored-by: Victor Stinner <[email protected]>
@vstinner
vstinner deleted the unicode_doc branch August 25, 2023 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@vstinner @miss-islington @bedevere-bot @serhiy-storchaka @Yhg1s
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.