GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — asyncio.streams.open_connection remove loop from docstring by tgbugs · Pull Request #108528 · python/cpython

Conversation

tgbugs commented Aug 27, 2023

Copy link

Copy Markdown

Contributor

asyncio.streams.open_connection no longer accepts loop as a keyword argument and providing it causes:
TypeError: BaseEventLoop.create_connection() got an unexpectedkeyword argument 'loop' therefore remove it from the docstring.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          asyncio.streams.open_connection remove loop from docstring

981fd95

asyncio.streams.open_connection no longer accepts loop as a
keyword argument and providing it causes:
TypeError: BaseEventLoop.create_connection() got an unexpectedkeyword argument 'loop'
therefore remove it from the docstring.

tgbugs requested review from 1st1, asvetlov, gvanrossum, kumaraditya303 and willingc as code owners

August 27, 2023 04:39

ghost commented Aug 27, 2023 •

edited by ghost

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

All commit authors signed the Contributor License Agreement.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot commented Aug 27, 2023

Copy link

Copy Markdown

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot added the awaiting review label

Aug 27, 2023

tgbugs commented Aug 27, 2023

Copy link

Copy Markdown

Contributor Author

This is a trivial change so if someone who has signed the CLA wants to submit it I don't mind.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

gvanrossum added skip issue skip news labels

Sep 13, 2023

gvanrossum approved these changes

Sep 13, 2023

View reviewed changes

bedevere-app Bot added awaiting core review and removed awaiting review labels

Sep 13, 2023


          Merge branch 'main' into patch-1

11b4e66

gvanrossum added needs backport to 3.11

only security fixes

needs backport to 3.12 only security fixes labels

Sep 13, 2023

gvanrossum commented Sep 13, 2023

Copy link

Copy Markdown

Member

@tgbugs: Could you please sign the CLA? It would really be much easier that way -- I can't merge without it.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

tgbugs commented Sep 27, 2023

Copy link

Copy Markdown

Contributor Author

@gvanrossum CLA signed.

gvanrossum reacted with thumbs up emoji

All reactions

👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

gvanrossum merged commit e721f7a into python:main

Sep 27, 2023

miss-islington commented Sep 27, 2023

Copy link

Copy Markdown

Contributor

Thanks @tgbugs for the PR, and @gvanrossum for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-app Bot removed the awaiting core review label

Sep 27, 2023

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Sep 27, 2023


          Remove loop from docstring for asyncio.streams.open_connection (pytho…

b37421a

…nGH-108528)

(cherry picked from commit e721f7a)

Co-authored-by: Tom Gillespie <[email protected]>

bedevere-app Bot commented Sep 27, 2023

Copy link

Copy Markdown

GH-109941 is a backport of this pull request to the 3.12 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-app Bot removed the needs backport to 3.12 only security fixes label

Sep 27, 2023

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Sep 27, 2023


          Remove loop from docstring for asyncio.streams.open_connection (pytho…

836f768

…nGH-108528)

(cherry picked from commit e721f7a)

Co-authored-by: Tom Gillespie <[email protected]>

bedevere-app Bot commented Sep 27, 2023

Copy link

Copy Markdown

GH-109942 is a backport of this pull request to the 3.11 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-app Bot removed the needs backport to 3.11 only security fixes label

Sep 27, 2023

gvanrossum commented Sep 27, 2023

Copy link

Copy Markdown

Member

@tgbugs I just realized (seconds after merging :-) that a similar change needs to be applied to open_connection(). Are you interested in taking that on, now that you've got the CLA signed and all?

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

serhiy-storchaka pushed a commit that referenced this pull request

Sep 27, 2023


          [3.11] Remove loop from docstring for asyncio.streams.open_connection (…

0a69de7

…GH-108528) (#109942)

Remove loop from docstring for asyncio.streams.open_connection (GH-108528)
(cherry picked from commit e721f7a)

Co-authored-by: Tom Gillespie <[email protected]>

tgbugs commented Sep 27, 2023 via email

Copy link

Copy Markdown

Contributor Author

Happy to, but won't be able to get to it until late next week of that matters.

…

On Wed, Sep 27, 2023, 12:42 Guido van Rossum ***@***.***> wrote: @tgbugs <https://github.com/tgbugs> I just realized (seconds after merging :-) that a similar change needs to be applied to open_connection(). Are you interested in taking that on, now that you've got the CLA signed and all? — Reply to this email directly, view it on GitHub <#108528 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABAZYABLAISZZEKVQDC75XLX4OOCRANCNFSM6AAAAAA4ABRYYM> . You are receiving this because you were mentioned.Message ID: ***@***.***>

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

gvanrossum commented Sep 27, 2023

Copy link

Copy Markdown

Member

@tgbugs No problem, take your time.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

csm10495 pushed a commit to csm10495/cpython that referenced this pull request

Sep 28, 2023


          Remove loop from docstring for asyncio.streams.open_connection (pytho…

14530dd

…n#108528)

Yhg1s pushed a commit that referenced this pull request

Oct 2, 2023


          [3.12] Remove loop from docstring for asyncio.streams.open_connection (…

3ab9fda

…GH-108528) (#109941)

Remove loop from docstring for asyncio.streams.open_connection (GH-108528)
(cherry picked from commit e721f7a)

Co-authored-by: Tom Gillespie <[email protected]>

Glyphack pushed a commit to Glyphack/cpython that referenced this pull request

Sep 2, 2024


          Remove loop from docstring for asyncio.streams.open_connection (pytho…

5c16f55

…n#108528)

Reviewers

gvanrossum

gvanrossum approved these changes

1st1

Awaiting requested review from 1st1

1st1 is a code owner

asvetlov

Awaiting requested review from asvetlov

asvetlov is a code owner

kumaraditya303

Awaiting requested review from kumaraditya303

kumaraditya303 is a code owner

willingc

Awaiting requested review from willingc

willingc is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

tgbugs commented Aug 27, 2023

Uh oh!

ghost commented Aug 27, 2023 • edited by ghost Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bedevere-bot commented Aug 27, 2023

Uh oh!

tgbugs commented Aug 27, 2023

Uh oh!

gvanrossum commented Sep 13, 2023

Uh oh!

tgbugs commented Sep 27, 2023

Uh oh!

miss-islington commented Sep 27, 2023

Uh oh!

bedevere-app Bot commented Sep 27, 2023

Uh oh!

bedevere-app Bot commented Sep 27, 2023

Uh oh!

gvanrossum commented Sep 27, 2023

Uh oh!

tgbugs commented Sep 27, 2023 via email

Uh oh!

gvanrossum commented Sep 27, 2023

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

ghost commented Aug 27, 2023 •

edited by ghost

Loading

Uh oh!

There was an error while loading. Please reload this page.