GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.12] GH-106176, GH-104702: Fix reference leak when importing across multiple threads (GH-108497) by miss-islington · Pull Request #108612 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented Aug 29, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

(cherry picked from commit 5f85b44)

Co-authored-by: Brett Cannon [email protected]

  • Issue: test_import.test_concurrency leaks ref on Windows #106176

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@brettcannon @miss-islington
pythonGH-106176, pythonGH-104702: Fix reference leak when importing a…
d2f0afd 
…cross multiple threads (pythonGH-108497)

(cherry picked from commit 5f85b44)

Co-authored-by: Brett Cannon <[email protected]>
@miss-islington
miss-islington requested review from brettcannon, encukou, ericsnowcurrently, ncoghlan and warsaw as code owners August 29, 2023 07:17
This was referenced Aug 29, 2023
test_import.test_concurrency leaks ref on Windows #106176
Closed
GH-106176, GH-104702: Fix reference leak when importing across multiple threads #108497
Merged
@bedevere-bot bedevere-bot added the awaiting review label Aug 29, 2023
vstinner
vstinner approved these changes Aug 29, 2023
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good bot.

That's an important refleak fix. Refleaks buildbots are failing for a few weeks because of it.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Aug 29, 2023
@Eclips4 Eclips4 assigned Yhg1s Aug 29, 2023
Eclips4
Eclips4 approved these changes Aug 29, 2023
View reviewed changes
@Eclips4 Eclips4 mentioned this pull request May 21, 2023
test_pickle are leaked on Windows #104702
Closed
@Yhg1s
Yhg1s merged commit c942fae into python:3.12 Aug 29, 2023
@bedevere-bot bedevere-bot removed the awaiting merge label Aug 29, 2023
@miss-islington
miss-islington deleted the backport-5f85b44-3.12 branch August 29, 2023 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes
@Eclips4 Eclips4 Eclips4 approved these changes
@brettcannon brettcannon Awaiting requested review from brettcannon brettcannon is a code owner
@encukou encukou Awaiting requested review from encukou encukou is a code owner
@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner
@ncoghlan ncoghlan Awaiting requested review from ncoghlan ncoghlan is a code owner
@warsaw warsaw Awaiting requested review from warsaw warsaw is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

@Yhg1s Yhg1s

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@miss-islington @vstinner @Eclips4 @Yhg1s @bedevere-bot @brettcannon
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.