Description

Eclips4

opened on May 20, 2023

Issue body actions

Tried on current main branch.

./python -m test -R 3:3 test_pickle
Running Debug|x64 interpreter...
0:00:00 Run tests sequentially
0:00:00 [1/1] test_pickle
beginning 6 repetitions
123456
......
test_pickle leaked [13, 12, 173] references, sum=198
test_pickle leaked [11, 12, 113] memory blocks, sum=136
test_pickle failed (reference leak) in 4 min 30 sec

== Tests result: FAILURE ==

1 test failed:
    test_pickle

Total duration: 4 min 30 sec
Tests result: FAILURE

Also, I cannot reproduce it in Linux (WSL, Ubuntu 20.04)

Linked PRs

• gh-106176: Fix reference leak in importlib/_bootstrap.py #106207
• GH-106176, GH-104702: Fix reference leak when importing across multiple threads #108497
• [3.12] GH-106176, GH-104702: Fix reference leak when importing across multiple threads (GH-108497) #108612

Activity

1. Eclips4

   added

   type-bugAn unexpected behavior, bug, or errorAn unexpected behavior, bug, or error

   on May 20, 2023
2. AlexWaygood

   added

   OS-windows

   on May 20, 2023
3. Eclips4 commented on May 21, 2023

   

   Eclips4

   on May 21, 2023

   MemberAuthor

   More actions

   Fantastic... I can't reproduce it anymore. I just try found bad commit using git bisect...
   But I've found reference leak in another way.

    ./python -m test -R 3:3 test_pickle -m PyUnpicklerTests
   Running Debug|x64 interpreter...
   0:00:00 Run tests sequentially
   0:00:00 [1/1] test_pickle
   beginning 6 repetitions
   123456
   ......
   test_pickle leaked [4, 4, 4] references, sum=12
   test_pickle leaked [4, 4, 4] memory blocks, sum=12
   test_pickle failed (reference leak)
   
   == Tests result: FAILURE ==
   
   1 test failed:
       test_pickle
   
   Total duration: 908 ms
   Tests result: FAILURE
4. Eclips4 commented on May 21, 2023

   

   Eclips4

   on May 21, 2023

   MemberAuthor

   More actions

   First bad commit: #94504
   Also, I know about some refleaks in test_import. (#102251)
   What is the relationship with this issue and test_import issue?
   Seems that both introduced in #94504 PR.
5. sunmy2019 commented on May 21, 2023

   

   sunmy2019

   on May 21, 2023

   Member

   More actions

   Seems all ref leaks come from test_unpickle_module_race

   If this test is removed from AbstractUnpickleTests, all ref leaks are gone.
6. vstinner

   added a commit that references this issue on Aug 29, 2023

   GH-106176, GH-104702: Fix reference leak when importing across multip…

   5f85b44
7. miss-islington

   added a commit that references this issue on Aug 29, 2023

   pythonGH-106176, pythonGH-104702: Fix reference leak when importing a…

   d2f0afd
8. Yhg1s

   added a commit that references this issue on Aug 29, 2023

   [3.12] GH-106176, GH-104702: Fix reference leak when importing across…

   c942fae
9. Eclips4

   closed this as completedon Aug 29, 2023

Issue actions