GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-108455: Simplify the peg_generator mypy config by AlexWaygood · Pull Request #108620 · python/cpython

Conversation

@AlexWaygood

@AlexWaygood AlexWaygood commented Aug 29, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

This simplifies the mypy config for the peg_generator, making it easier to see exactly which options from mypy's --strict mode can't currently be enabled

  • Issue: Run mypy on Tools/peg_generator #108455

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@AlexWaygood
pythongh-108455: Simplify the peg_generator mypy config
d52c15a
@AlexWaygood
AlexWaygood requested review from lysnikolaou and pablogsal as code owners August 29, 2023 09:21
@bedevere-bot bedevere-bot mentioned this pull request Aug 24, 2023
Run mypy on Tools/peg_generator #108455
Closed
@bedevere-bot bedevere-bot added the awaiting core review label Aug 29, 2023
@AlexWaygood AlexWaygood added the skip news label Aug 29, 2023
@AlexWaygood
AlexWaygood requested review from hauntsaninja and sobolevn August 29, 2023 09:22
@AlexWaygood
more
d326921
sobolevn
sobolevn approved these changes Aug 29, 2023
View reviewed changes

@sobolevn sobolevn left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I was working on a similar PR.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
AlexWaygood reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@AlexWaygood
AlexWaygood enabled auto-merge (squash) August 29, 2023 10:20
@AlexWaygood
AlexWaygood merged commit c879b9f into python:main Aug 29, 2023
@bedevere-bot bedevere-bot removed the awaiting core review label Aug 29, 2023
@sobolevn sobolevn mentioned this pull request Aug 29, 2023
gh-108455: Use strict_optional=True for grammar_parser #108629
Merged
@AlexWaygood
AlexWaygood deleted the peg-mypy-conf branch August 29, 2023 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sobolevn sobolevn sobolevn approved these changes
@pablogsal pablogsal Awaiting requested review from pablogsal pablogsal is a code owner
@lysnikolaou lysnikolaou Awaiting requested review from lysnikolaou lysnikolaou is a code owner
@hauntsaninja hauntsaninja Awaiting requested review from hauntsaninja

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@AlexWaygood @sobolevn @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.