Description

sobolevn

opened on Aug 24, 2023

Issue body actions

Feature or enhancement

Now that we have mypy infrastructure ready https://github.com/python/cpython/blob/main/.github/workflows/mypy.yml we can add more things to the test.

https://github.com/python/cpython/tree/main/Tools/peg_generator has mypy.ini and annotations. So, let's check it as well.

How I plan to do it (separate PRs):

1. Start small with the CI job itself and initial fixes
2. Add types-setuptools dependency and fix more problems
3. Update config to be stricter and refactor

Linked PRs

• gh-108455: Run mypy on Tools/peg_generator #108456
• gh-108455: Simplify the peg_generator mypy config #108620
• gh-108455: peg_generator: make the mypy config slightly stricter #108627
• gh-108455: Use strict_optional=True for grammar_parser #108629
• gh-108455: peg_generator: install two stubs packages before running mypy #108637
• gh-108455: peg_generator: use types-setuptools==68.1.0.1 in CI #108697
• gh-108455: peg_generator: enable mypy's --warn-unreachable setting and redundant-expr error code #109160

Activity

1. sobolevn

   added

   type-featureA feature request or enhancementA feature request or enhancement

   on Aug 24, 2023
2. sobolevn

   self-assigned this

   on Aug 24, 2023
3. sobolevn

   added 2 commits that reference this issue on Aug 24, 2023

   pythongh-108455: Run `mypy` on `Tools/peg_generator`

   a33e5a9

   pythongh-108455: Run `mypy` on `Tools/peg_generator`

   c08b596
4. pablogsal

   added a commit that references this issue on Aug 28, 2023

   gh-108455: Run `mypy` on `Tools/peg_generator` (#108456)

   cf7ba83
5. AlexWaygood

   added 2 commits that reference this issue on Aug 29, 2023

   pythongh-108455: Simplify the peg_generator mypy config

   d52c15a

   gh-108455: Simplify the peg_generator mypy config (#108620)

   c879b9f
6. sobolevn

   added a commit that references this issue on Aug 29, 2023

   pythongh-108455: Use `strict_optional=True` for `grammar_parser`

   2d5e594
7. AlexWaygood

   added 3 commits that reference this issue on Aug 29, 2023

   gh-108455: peg_generator: make the mypy config slightly stricter (#10…

   0d140b8

   gh-108455: peg generator: Use `strict_optional=True` for `grammar_par…

   f8be2e2

   gh-108455: peg_generator: install two stubs packages before running m…

   77e8f23
8. carljm

   added a commit that references this issue on Aug 30, 2023

   Merge branch 'main' into icompexc

   37377e6
9. AlexWaygood

   added a commit that references this issue on Aug 31, 2023

   gh-108455: peg_generator: use `types-setuptools==68.1.0.1` in CI (#10…

   b89b838
10. pablogsal

    closed this as completedin #109160on Sep 8, 2023
11. pablogsal

    added a commit that references this issue on Sep 8, 2023

    gh-108455: peg_generator: enable mypy's `--warn-unreachable` setting …

    697c9dc

Issue actions