GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-108455: peg_generator: make the mypy config slightly stricter by AlexWaygood · Pull Request #108627 · python/cpython

Conversation

@AlexWaygood

@AlexWaygood AlexWaygood commented Aug 29, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

This picks some low-hanging fruit when it comes to the mypy config, enabling various stricter settings that don't require large code changes:

  • Enable --no-explicit-reexport
  • Enable the truthy-bool and ignore-without-code error codes
  • Explicitly note in our config file that --warn-unreachable can't yet be enabled. (It would take several code changes before we could enable it; it's deferred for now.)
  • Issue: Run mypy on Tools/peg_generator #108455

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
AlexWaygood added 4 commits August 29, 2023 11:42
@AlexWaygood
Enable --no-implicit-reexport
1764adb
@AlexWaygood
Enable the truthy-bool error code
d4a5b56
@AlexWaygood
Enable the ignore-without-code error code
c7372c1
@AlexWaygood
Explicitly note that --warn-unreachable cannot yet be enabled
d4912ef
@AlexWaygood
AlexWaygood requested a review from sobolevn August 29, 2023 10:53
@AlexWaygood
AlexWaygood requested review from lysnikolaou and pablogsal as code owners August 29, 2023 10:53
@bedevere-bot bedevere-bot mentioned this pull request Aug 29, 2023
Run mypy on Tools/peg_generator #108455
Closed
@bedevere-bot bedevere-bot added the awaiting core review label Aug 29, 2023
@AlexWaygood AlexWaygood added the skip news label Aug 29, 2023
sobolevn
sobolevn approved these changes Aug 29, 2023
View reviewed changes
@AlexWaygood
AlexWaygood enabled auto-merge (squash) August 29, 2023 11:19
@AlexWaygood
AlexWaygood merged commit 0d140b8 into python:main Aug 29, 2023
@bedevere-bot bedevere-bot removed the awaiting core review label Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sobolevn sobolevn sobolevn approved these changes
@pablogsal pablogsal Awaiting requested review from pablogsal pablogsal is a code owner
@lysnikolaou lysnikolaou Awaiting requested review from lysnikolaou lysnikolaou is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@AlexWaygood @sobolevn @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.