GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.11] Use non alternate name for Kyiv (GH-108533) by miss-islington · Pull Request #108641 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented Aug 29, 2023

Copy link
Copy Markdown
Contributor

tzdata provides Kiev as an alternative to Kyiv:

https://sources.debian.org/src/tzdata/2023c-10/backward/?hl=314GH-L314

But Debian moved it to the tzdata-legacy package breaking the test:

https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1050530

This patch switches to the name provided by tzdata.
(cherry picked from commit 7659128)

Co-authored-by: Jochen Sprickerhof [email protected]

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@jspricke @miss-islington
Use non alternate name for Kyiv (pythonGH-108533)
9ba20c4 
tzdata provides Kiev as an alternative to Kyiv:

https://sources.debian.org/src/tzdata/2023c-10/backward/?hl=314GH-L314

But Debian moved it to the tzdata-legacy package breaking the test:

https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1050530

This patch switches to the name provided by tzdata.
(cherry picked from commit 7659128)

Co-authored-by: Jochen Sprickerhof <[email protected]>
@miss-islington
miss-islington requested a review from a team as a code owner August 29, 2023 15:01
@ghost

ghost commented Aug 29, 2023

Copy link
Copy Markdown

The following commit authors need to sign the Contributor License Agreement:

  • [email protected]

Click the button to sign:
CLA not signed
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot added the skip issue label Aug 29, 2023
@bedevere-bot bedevere-bot mentioned this pull request Aug 29, 2023
Use non alternate name for Kyiv #108533
Merged
@bedevere-bot bedevere-bot added skip news tests Tests in the Lib/test dir awaiting review labels Aug 29, 2023
@serhiy-storchaka
serhiy-storchaka enabled auto-merge (squash) August 29, 2023 15:02
@serhiy-storchaka
serhiy-storchaka merged commit 34f84f2 into python:3.11 Aug 29, 2023
@bedevere-bot bedevere-bot removed the awaiting review label Aug 29, 2023
@miss-islington
miss-islington deleted the backport-7659128-3.11 branch August 29, 2023 15:48
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request Aug 29, 2023
@serhiy-storchaka
Revert "[3.11] Use non alternate name for Kyiv (pythonGH-108533) (pyt…
a0f1cf3 
…honGH-108641)"

This reverts commit 34f84f2.
@bedevere-bot

bedevere-bot commented Aug 29, 2023

Copy link
Copy Markdown

GH-108650 is a backport of this pull request to the 3.11 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
serhiy-storchaka added a commit that referenced this pull request Aug 29, 2023
@serhiy-storchaka
[3.11] Revert "[3.11] Use non alternate name for Kyiv (GH-108533) (GH…
2e4c3ef 
…-108641)" (GH-108650)

This reverts commit 34f84f2.

It broke tests on the Debian and macOS buildbots.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip issue skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@miss-islington @bedevere-bot @serhiy-storchaka @jspricke
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.