GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-108717: Speedup `os.DirEntry.is_junction` function by sobolevn · Pull Request #108718 · python/cpython

Conversation

@sobolevn

@sobolevn sobolevn commented Aug 31, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Refs #99548

  • Issue: os.DirEntry.is_junction can be ~twice as fast #108717

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@sobolevn
pythongh-108717: Speedup os.DirEntry.is_junction function
d70b2b0
@sobolevn
sobolevn requested review from barneygale, erlend-aasland and eryksun August 31, 2023 12:55
@bedevere-bot bedevere-bot mentioned this pull request Aug 31, 2023
os.DirEntry.is_junction can be ~twice as fast #108717
Closed
@bedevere-bot bedevere-bot added the awaiting review label Aug 31, 2023
@sobolevn sobolevn added the skip news label Aug 31, 2023
@sobolevn sobolevn mentioned this pull request Aug 31, 2023
Update os.DirEntry to 3.12 python/typeshed#10643
Merged
erlend-aasland
erlend-aasland approved these changes Aug 31, 2023
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels Aug 31, 2023
@erlend-aasland erlend-aasland linked an issue Aug 31, 2023 that may be closed by this pull request
os.DirEntry.is_junction can be ~twice as fast #108717
Closed
@sobolevn

sobolevn commented Aug 31, 2023

Copy link
Copy Markdown
Member Author

@erlend-aasland do you want to wait for other opinions as well before merging? :)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@erlend-aasland

erlend-aasland commented Aug 31, 2023

Copy link
Copy Markdown
Contributor

@erlend-aasland do you want to wait for other opinions as well before merging? :)

Since you requested reviews from @eryksun and @barneygale, I thought it would be nice to give them a chance to review before landing :)
sobolevn reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
serhiy-storchaka
serhiy-storchaka approved these changes Sep 5, 2023
View reviewed changes
barneygale
barneygale approved these changes Sep 5, 2023
View reviewed changes
@erlend-aasland

erlend-aasland commented Sep 6, 2023

Copy link
Copy Markdown
Contributor

@sobolevn, can you fix the conflicts (probably just a regen clinic)?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@sobolevn
Merge
03f0e84
kumaraditya303
kumaraditya303 approved these changes Sep 6, 2023
View reviewed changes
@kumaraditya303
kumaraditya303 enabled auto-merge (squash) September 6, 2023 08:28
@kumaraditya303
kumaraditya303 merged commit 65a2bce into python:main Sep 6, 2023
@bedevere-bot bedevere-bot removed the awaiting merge label Sep 6, 2023
@sobolevn sobolevn mentioned this pull request Sep 6, 2023
Make os.DirEntry.is_symlink ~twice as fast #108985
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@barneygale barneygale barneygale approved these changes
@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes
@erlend-aasland erlend-aasland erlend-aasland approved these changes
@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes
@eryksun eryksun Awaiting requested review from eryksun

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

os.DirEntry.is_junction can be ~twice as fast

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@sobolevn @erlend-aasland @barneygale @serhiy-storchaka @kumaraditya303 @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.