Description

sobolevn

opened on Sep 6, 2023

Issue body actions

While fixing a merge conflict in #108718 I've noticed that I've missed the same problem in os.DirEntry.is_symlink.

I will send a new PR since the original one was already merged

Refs #108717

Linked PRs

• gh-108985: Make os.DirEntry.is_symlink ~twice as fast #108986

Activity

1. sobolevn

   added

   performancePerformance or resource usagePerformance or resource usage

   extension-modulesC modules in the Modules dirC modules in the Modules dir

   on Sep 6, 2023
2. sobolevn

   self-assigned this

   on Sep 6, 2023
3. sobolevn

   added a commit that references this issue on Sep 6, 2023

   pythongh-108985: Make `os.DirEntry.is_symlink` ~twice as fast

   ab407e1
4. sobolevn commented on Sep 6, 2023

   

   sobolevn

   on Sep 6, 2023

   MemberAuthor

   More actions

   False alarm:

   #elif defined(HAVE_DIRENT_D_TYPE)
       /* POSIX */
       if (self->d_type != DT_UNKNOWN)
           return self->d_type == DT_LNK;
       else
           return DirEntry_test_mode(defining_class, self, 0, S_IFLNK);
   #else
       /* POSIX without d_type */
       return DirEntry_test_mode(defining_class, self, 0, S_IFLNK);
   #endif

   Reacted by Erlend E. Aasland
5. sobolevn

   closed this as not plannedon Sep 6, 2023

Issue actions