GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-108765: Remove old prototypes from pyport.h by vstinner · Pull Request #108782 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented Sep 1, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Move prototypes of gethostname(), _getpty() and struct termios from pyport.h to the C code using them: posixmodule.c, socketmodule.c and termios.c.

Replace "#ifdef SOLARIS" with "#ifdef __sun".

  • Issue: C API: Cleanup header files #108765

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner
pythongh-108765: Remove old prototypes from pyport.h
7385795 
Move prototypes of gethostname(), _getpty() and struct termios from
pyport.h to the C code using them: posixmodule.c, socketmodule.c and
termios.c.

Replace "#ifdef SOLARIS" with "#ifdef __sun".
@bedevere-bot bedevere-bot mentioned this pull request Sep 1, 2023
C API: Cleanup header files #108765
Closed
@vstinner vstinner added the skip news label Sep 1, 2023
This was referenced Sep 1, 2023
gh-108765: Remove legacy prototypes from pyport.h #108776
Closed
gh-108765: [TEST] Test combined Python.h changes #108784
Closed
@vstinner
vstinner marked this pull request as ready for review September 2, 2023 13:46
@bedevere-bot bedevere-bot added the awaiting core review label Sep 2, 2023
@vstinner

vstinner commented Sep 2, 2023

Copy link
Copy Markdown
Member Author

Buildbots are happy with this change: #108784
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner
vstinner merged commit 1f3e797 into python:main Sep 2, 2023
@vstinner
vstinner deleted the prototypes branch September 2, 2023 13:46
@bedevere-bot bedevere-bot removed the awaiting core review label Sep 2, 2023
@vstinner

vstinner commented Sep 2, 2023

Copy link
Copy Markdown
Member Author

@kulikjak: It would be nice if you can double check the Solaris change:

Replace "#ifdef SOLARIS" with "#ifdef __sun".
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@kulikjak

kulikjak commented Sep 2, 2023

Copy link
Copy Markdown
Contributor

Hi @vstinner, can you, please, remove this part completely? There is already and issue and PR for this that is forgotten a little:
#63760
#23208

As mentioned there, gethostname() is defined now and both Oracle Solaris and OpenSolaris forks remove it:
https://github.com/oracle/solaris-userland/blob/master/components/python/python37/patches/15-gethostname.patch
https://github.com/OpenIndiana/oi-userland/blob/oi/hipster/components/python/python37/patches/15-gethostname.patch
https://github.com/omniosorg/omnios-build/blob/master/build/python27/patches/24-gethostname.patch

As for the define guard, if defined(__sun) && defined(__SVR4) is the best way to detect Solaris. (Although I guess there isn't that many people running 30+ years old pre SRV4 SunOS systems and building latest Python :))
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@kulikjak

kulikjak commented Sep 2, 2023

Copy link
Copy Markdown
Contributor

I just realized that it's merged already - I rebased that older PR to remove it.
#23208
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@vstinner @kulikjak @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.