GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-19561: Remove unnecessary gethostname() prototype for Solaris by kulikjak · Pull Request #23208 · python/cpython

Conversation

@kulikjak

@kulikjak kulikjak commented Nov 9, 2020 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

This is no longer necessary because Solaris included gethostname() in its header files more than 15 years ago.

https://bugs.python.org/issue19561

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label Nov 9, 2020
@bedevere-bot bedevere-bot added the awaiting review label Nov 9, 2020
jstasiak
jstasiak approved these changes Nov 12, 2020
View reviewed changes

@jstasiak jstasiak left a comment

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just tested this on OpenIndiana, works fine.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
kulikjak reacted with hooray emoji
All reactions
  • 🎉 1 reaction
@bedevere-bot bedevere-bot added awaiting core review and removed awaiting review labels Nov 12, 2020
@github-actions

github-actions Bot commented Dec 16, 2020

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 5 days
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label Dec 16, 2020
@kulikjak

kulikjak commented Dec 16, 2020

Copy link
Copy Markdown
Contributor Author

I cannot remove the stale label, but I am still very interested in this being merged.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot removed the stale Stale PR or inactive for long period of time. label Dec 17, 2020
@github-actions

github-actions Bot commented Jan 16, 2021

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label Jan 16, 2021
@kulikjak

kulikjak commented Jan 16, 2021

Copy link
Copy Markdown
Contributor Author

Still relevant...
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot removed the stale Stale PR or inactive for long period of time. label Jan 17, 2021
@ezio-melotti ezio-melotti removed the CLA signed label Jul 13, 2022
@kulikjak
kulikjak force-pushed the fix-gethostname-declaration branch 3 times, most recently from 3f551bd to d650b0c Compare August 23, 2022 12:03
@iritkatriel
iritkatriel requested a review from Yhg1s November 27, 2022 22:52
@arhadthedev

arhadthedev commented Mar 22, 2023

Copy link
Copy Markdown
Member

@jcea (as an OpenSolaris expert)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@kulikjak
kulikjak force-pushed the fix-gethostname-declaration branch from cb868a7 to 93e64c8 Compare May 9, 2023 13:02
@kulikjak kulikjak mentioned this pull request Sep 2, 2023
gh-108765: Remove old prototypes from pyport.h #108782
Merged
@kulikjak
Remove unnecessary gethostname() prototype for Solaris
d2fc237
@kulikjak
kulikjak force-pushed the fix-gethostname-declaration branch from 93e64c8 to d2fc237 Compare September 2, 2023 15:32
@risto3 risto3 mannequin mentioned this pull request Sep 2, 2023
request to reopen Issue837046 - pyport.h redeclares gethostname() if SOLARIS is defined #63760
Closed
@vstinner vstinner mentioned this pull request Sep 2, 2023
gh-63760: Don't declare gethostname() on Solaris #108817
Merged
@vstinner

vstinner commented Sep 2, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

I proposed PR #108817 with more details on the issue.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@kulikjak

kulikjak commented Sep 3, 2023

Copy link
Copy Markdown
Contributor Author

Fixed with #108817.
vstinner reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@kulikjak kulikjak closed this Sep 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Yhg1s Yhg1s Awaiting requested review from Yhg1s
1 more reviewer
@jstasiak jstasiak jstasiak approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting core review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@kulikjak @arhadthedev @vstinner @jstasiak @the-knights-who-say-ni @ezio-melotti @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.