GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — bpo-45229: Make ElementTree tests discoverable by serhiy-storchaka · Pull Request #108859 · python/cpython

Conversation

@serhiy-storchaka

@serhiy-storchaka serhiy-storchaka commented Sep 4, 2023 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: Always use unittest for collecting tests in regrtests #89392

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@serhiy-storchaka
bpo-45229: Make ElementTree tests discoverable
bac2b39
@serhiy-storchaka serhiy-storchaka added tests Tests in the Lib/test dir skip news needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Sep 4, 2023
@serhiy-storchaka
serhiy-storchaka requested a review from vstinner September 4, 2023 07:21
@bedevere-bot bedevere-bot added the awaiting core review label Sep 4, 2023
@vstinner

vstinner commented Sep 4, 2023

Copy link
Copy Markdown
Member

Without the PR, main branch:

$ ./python -m test -v test_xml_etree_c
(...)
Warning -- test_xml_etree_c test runner returned None: <function test_main at 0x7f94a1758650>

Total duration: 2.3 sec
Total tests: run=0
Total test files: run=1/1

With the PR:

$ ./python -m test -v test_xml_etree_c
(...)
Total tests: run=208 skipped=6
Total test files: run=1/1

regrtest is able to count the number of tests, nice!

I counted manually the number of tests in the main branch (count the number of lines in short), and I also see 208 tests! I only see 5 skipped tests, but here 6 are announced. Aha, interesting!

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@serhiy-storchaka

serhiy-storchaka commented Sep 4, 2023

Copy link
Copy Markdown
Member Author

I only see 5 skipped tests, but here 6 are announced.

It counts skipped NoAcceleratorTest. In the old code it was not added to the explicit list of test classes.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@serhiy-storchaka
serhiy-storchaka merged commit 074ac1f into python:main Sep 4, 2023
@miss-islington

miss-islington commented Sep 4, 2023

Copy link
Copy Markdown
Contributor

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot bedevere-bot removed the awaiting core review label Sep 4, 2023
@serhiy-storchaka
serhiy-storchaka deleted the test-etree-discover branch September 4, 2023 10:04
@miss-islington

miss-islington commented Sep 4, 2023

Copy link
Copy Markdown
Contributor

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 074ac1f72e392a576516639f650bac0519d1cb52 3.12

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@miss-islington miss-islington assigned serhiy-storchaka Sep 4, 2023
@miss-islington

miss-islington commented Sep 4, 2023

Copy link
Copy Markdown
Contributor

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 074ac1f72e392a576516639f650bac0519d1cb52 3.11

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request Sep 4, 2023
@serhiy-storchaka
[3.12] bpo-45229: Make ElementTree tests discoverable (pythonGH-108859).
5959ec1
(cherry picked from commit 074ac1f)

Co-authored-by: Serhiy Storchaka <[email protected]>
@bedevere-bot

bedevere-bot commented Sep 4, 2023

Copy link
Copy Markdown

GH-108873 is a backport of this pull request to the 3.12 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot bedevere-bot removed the needs backport to 3.12 only security fixes label Sep 4, 2023
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request Sep 4, 2023
@serhiy-storchaka
[3.11] bpo-45229: Make ElementTree tests discoverable (pythonGH-108859).
64e1533
(cherry picked from commit 074ac1f)

Co-authored-by: Serhiy Storchaka <[email protected]>
@bedevere-bot

bedevere-bot commented Sep 4, 2023

Copy link
Copy Markdown

GH-108874 is a backport of this pull request to the 3.11 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Sep 4, 2023
serhiy-storchaka added a commit that referenced this pull request Sep 4, 2023
@serhiy-storchaka
[3.11] bpo-45229: Make ElementTree tests discoverable (GH-108859) (GH…
3fd6ada
…-108874)

(cherry picked from commit 074ac1f)
@serhiy-storchaka serhiy-storchaka mentioned this pull request Sep 4, 2023
Always use unittest for collecting tests in regrtests #89392
Closed
@vstinner

vstinner commented Sep 4, 2023

Copy link
Copy Markdown
Member

It counts skipped NoAcceleratorTest. In the old code it was not added to the explicit list of test classes.

Minor but nice improvement to take :-)

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Yhg1s pushed a commit that referenced this pull request Sep 5, 2023
@serhiy-storchaka
[3.12] bpo-45229: Make ElementTree tests discoverable (GH-108859) (#1…
e76b0b7
…08873)

[3.12] bpo-45229: Make ElementTree tests discoverable (GH-108859).
(cherry picked from commit 074ac1f)
@serhiy-storchaka serhiy-storchaka removed their assignment Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner Awaiting requested review from vstinner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@serhiy-storchaka @vstinner @miss-islington @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.