GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.11] gh-108851: Fix tomllib recursion tests (#108853) by vstinner · Pull Request #109013 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented Sep 6, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Add get_recursion_available() and get_recursion_depth() functions to the test.support module.
  • Change infinite_recursion() default max_depth from 75 to 100.
  • Fix test_tomllib recursion tests for WASI buildbots: reduce the recursion limit and compute the maximum nested array/dict depending on the current available recursion limit.
  • test.pythoninfo logs sys.getrecursionlimit().
  • Enhance test_sys tests on sys.getrecursionlimit() and sys.setrecursionlimit().

Backport notes:

  • Set support.infinite_recursion() minimumum to 4 frames.
  • test_support.test_get_recursion_depth() uses limit-2, apparently f-string counts for 2 frames in Python 3.11.
  • test_sys.test_setrecursionlimit_to_depth() tests depth+2 instead of depth+1.

(cherry picked from commit 8ff1142)

  • Issue: test_tomllib.test_inline_array_recursion_limit() failed on wasm32-wasi 3.11 buildbot #108851

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@vstinner
pythongh-108851: Fix tomllib recursion tests (python#108853)
44a6efd
* Add get_recursion_available() and get_recursion_depth() functions
  to the test.support module.
* Change infinite_recursion() default max_depth from 75 to 100.
* Fix test_tomllib recursion tests for WASI buildbots: reduce the
  recursion limit and compute the maximum nested array/dict depending
  on the current available recursion limit.
* test.pythoninfo logs sys.getrecursionlimit().
* Enhance test_sys tests on sys.getrecursionlimit()
  and sys.setrecursionlimit().

Backport notes:

* Set support.infinite_recursion() minimum to 4 frames.
* test_support.test_get_recursion_depth() uses limit-2, apparently
  f-string counts for 2 frames in Python 3.11.
* test_sys.test_setrecursionlimit_to_depth() tests depth+2 instead of
  depth+1.

(cherry picked from commit 8ff1142)
@vstinner
vstinner requested a review from encukou as a code owner September 6, 2023 16:00
@bedevere-bot bedevere-bot added the awaiting core review label Sep 6, 2023
@bedevere-bot bedevere-bot mentioned this pull request Sep 6, 2023
test_tomllib.test_inline_array_recursion_limit() failed on wasm32-wasi 3.11 buildbot #108851
Closed
@vstinner
vstinner enabled auto-merge (squash) September 6, 2023 16:00
@bedevere-bot bedevere-bot mentioned this pull request Sep 6, 2023
gh-108851: Fix tomllib recursion tests #108853
Merged
@vstinner
vstinner merged commit 95eb984 into python:3.11 Sep 6, 2023
@vstinner
vstinner deleted the support_recursive311 branch September 6, 2023 16:40
@bedevere-bot bedevere-bot removed the awaiting core review label Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@encukou encukou Awaiting requested review from encukou encukou is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@vstinner @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.