Description

vstinner

opened on Sep 3, 2023

Issue body actions

test_tomllib.test_inline_array_recursion_limit() failed on wasm32-wasi 3.11 buildbot:

ERROR: test_inline_array_recursion_limit (test.test_tomllib.test_misc.TestMiscellaneous.test_inline_array_recursion_limit)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Lib/test/test_tomllib/test_misc.py", line 98, in test_inline_array_recursion_limit
    tomllib.loads(recursive_array_toml)
  File "/Lib/tomllib/_parser.py", line 102, in loads
    pos = key_value_rule(src, pos, out, header, parse_float)
          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Lib/tomllib/_parser.py", line 326, in key_value_rule
    pos, key, value = parse_key_value_pair(src, pos, parse_float)
                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Lib/tomllib/_parser.py", line 369, in parse_key_value_pair
    pos, value = parse_value(src, pos, parse_float)
                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Lib/tomllib/_parser.py", line 616, in parse_value
    return parse_array(src, pos, parse_float)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Lib/tomllib/_parser.py", line 420, in parse_array
    pos, val = parse_value(src, pos, parse_float)
               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  (...)
  File "/Lib/tomllib/_parser.py", line 416, in parse_array
    pos = skip_comments_and_array_ws(src, pos)
          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/Lib/tomllib/_parser.py", line 278, in skip_comments_and_array_ws
    pos = skip_chars(src, pos, TOML_WS_AND_NEWLINE)
          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
RecursionError: maximum recursion depth exceeded

link: https://buildbot.python.org/all/#/builders/1047/builds/908

Linked PRs

• gh-108851: Fix tomllib recursion tests #108853
• [3.12] gh-108851: Fix tomllib recursion tests (GH-108853) #109012
• [3.11] gh-108851: Fix tomllib recursion tests (#108853) #109013
• [3.11] gh-108851: Fix support.get_recursion_available() for USE_STACKCHECK #110127

Activity

1. vstinner

   added 9 commits that reference this issue on Sep 3, 2023

   pythongh-108851: Add support.get_recursion_available()

   014d864

   pythongh-108851: Add support.get_recursion_available()

   973459e

   pythongh-108851: Add support.get_recursion_available()

   d26aa6b

   pythongh-108851: Fix tomllib recusion tests

   31974ae

   pythongh-108851: Fix tomllib recursion tests

   ae8b9c8

   pythongh-108851: Fix tomllib recursion tests

   465362f

   pythongh-108851: Fix tomllib recursion tests

   61a977a

   pythongh-108851: Fix tomllib recursion tests

   989f06b

   pythongh-108851: Fix tomllib recursion tests

   81a978e
2. brettcannon

   added

   OS-wasi

   testsTests in the Lib/test dirTests in the Lib/test dir

   3.11only security fixesonly security fixes

   on Sep 5, 2023
3. vstinner

   added 2 commits that reference this issue on Sep 5, 2023

   pythongh-108851: Fix tomllib recursion tests

   a1b3414

   gh-108851: Fix tomllib recursion tests (#108853)

   8ff1142
4. miss-islington

   added a commit that references this issue on Sep 6, 2023

   pythongh-108851: Fix tomllib recursion tests (pythonGH-108853)

   949372b
5. 1 remaining item
6. vstinner

   added a commit that references this issue on Sep 6, 2023

   pythongh-108851: Fix tomllib recursion tests (python#108853)

   44a6efd
7. vstinner

   closed this as completedon Sep 6, 2023
8. vstinner

   added a commit that references this issue on Sep 6, 2023

   [3.11] gh-108851: Fix tomllib recursion tests (#108853) (#109013)

   95eb984
9. Yhg1s

   added a commit that references this issue on Sep 8, 2023

   [3.12] gh-108851: Fix tomllib recursion tests (GH-108853) (#109012)

   55d7e8f
10. vstinner

    added 2 commits that reference this issue on Sep 29, 2023

    pythongh-108851: Fix support.get_recursion_available() for USE_STACKC…

    8c50ad2

    [3.11] gh-108851: Fix support.get_recursion_available() for USE_STACK…

    190e8fb
11. markshannon commented on Nov 18, 2023

    

    markshannon

    on Nov 18, 2023

    Member

    More actions

    I don't understand what's going on here.
    Why does the test fail?
    Hacking the tests does not seem to be the right solution. Why not fix the underlying problem, or at least triage it first?
12. markshannon

    reopened this on Nov 18, 2023
13. markshannon commented on Nov 18, 2023

    

    markshannon

    on Nov 18, 2023

    Member

    More actions

    My mistake. I didn't see the all important 3.11 part.
    Still, we ought to record what the problem is on the issue, before fixing it.
14. markshannon

    closed this as completedon Nov 18, 2023
15. markshannon commented on Nov 18, 2023

    

    markshannon

    on Nov 18, 2023

    Member

    More actions

    So, why change 3.13 and 3.12, if this is a 3.11 issue?
16. markshannon

    reopened this on Nov 18, 2023
17. vstinner commented on Nov 27, 2023

    

    vstinner

    on Nov 27, 2023

    MemberAuthor

    More actions

    So, why change 3.13 and 3.12, if this is a 3.11 issue?

    First I saw the issue on 3.11, but in fact the 3 branches were affectected: 3.11, 3.12 and main.

    @markshannon: Did you reopen the issue because you want to make changes?
18. brettcannon commented on Dec 14, 2023

    

    brettcannon

    on Dec 14, 2023

    Member

    More actions

    Since all the buildbots are passing, I'm closing the issue as fixed.
19. brettcannon

    closed this as completedon Dec 14, 2023

Issue actions