GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-109050: Remove remaining tests for legacy Unicode C API by serhiy-storchaka · Pull Request #109068 · python/cpython

Conversation

@serhiy-storchaka

@serhiy-storchaka serhiy-storchaka commented Sep 7, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: Tests: remove C API tests using @requires_legacy_unicode_capi()? #109050

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@serhiy-storchaka
pythongh-109050: Remove remaining tests for legacy Unicode C API
6552ba2
@serhiy-storchaka serhiy-storchaka added tests Tests in the Lib/test dir skip news labels Sep 7, 2023
@serhiy-storchaka
serhiy-storchaka requested a review from rhettinger as a code owner September 7, 2023 08:19
@bedevere-bot bedevere-bot added the awaiting core review label Sep 7, 2023
@bedevere-bot bedevere-bot mentioned this pull request Sep 7, 2023
Tests: remove C API tests using @requires_legacy_unicode_capi()? #109050
Closed
@serhiy-storchaka
serhiy-storchaka requested review from vstinner and removed request for rhettinger September 7, 2023 10:53
vstinner
vstinner approved these changes Sep 8, 2023
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I just have a minor coding style remark.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Comment thread Lib/test/test_capi/test_getargs.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Sep 8, 2023
@serhiy-storchaka
Update test_getargs.py
31196b6
@serhiy-storchaka
serhiy-storchaka enabled auto-merge (squash) September 8, 2023 09:05
@serhiy-storchaka
serhiy-storchaka disabled auto-merge September 8, 2023 09:05
@serhiy-storchaka
serhiy-storchaka enabled auto-merge (squash) September 8, 2023 09:06
@serhiy-storchaka
Merge branch 'main' into remove-tests-legacy_unicode_capi
796562e
@serhiy-storchaka
serhiy-storchaka merged commit b4131a1 into python:main Sep 9, 2023
@bedevere-bot bedevere-bot removed the awaiting merge label Sep 9, 2023
@serhiy-storchaka
serhiy-storchaka deleted the remove-tests-legacy_unicode_capi branch July 1, 2026 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@serhiy-storchaka @vstinner @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.