Description

vstinner

opened on Sep 7, 2023

Issue body actions

The @test.support.requires_legacy_unicode_capi() decorators uses from _testcapi import unicode_legacy_string, but this module attribute has been remove since Python 3.12 by commit f9c9354, and so all tests using the decorator are now always skipped.

Should we now remove tests using @requires_legacy_unicode_capi() decorator? Or are these tests kept on purpose?

For example, this test is now always skipped:

$ ./python -m test test_capi -m test.test_capi.test_getargs.String_TestCase.test_Z -v

test_Z (test.test_capi.test_getargs.String_TestCase.test_Z) ... skipped 'requires legacy Unicode C API'

See also issue #92536 and PEP 623: Remove wstr from Unicode.

cc @methane @serhiy-storchaka

Linked PRs

• gh-109050: Remove remaining tests for legacy Unicode C API #109068

Activity

1. vstinner

   added

   testsTests in the Lib/test dirTests in the Lib/test dir

   topic-C-API

   on Sep 7, 2023
2. serhiy-storchaka

   added a commit that references this issue on Sep 7, 2023

   pythongh-109050: Remove remaining tests for legacy Unicode C API

   6552ba2
3. serhiy-storchaka commented on Sep 7, 2023

   

   serhiy-storchaka

   on Sep 7, 2023

   Member

   More actions

   I have examined them all, and they do not contain anything that could be tested. The fact that particular format units are errors is already tested in other tests.
4. serhiy-storchaka

   added a commit that references this issue on Sep 9, 2023

   gh-109050: Remove remaining tests for legacy Unicode C API (GH-109068)

   b4131a1
5. vstinner

   closed this as completedon Sep 9, 2023

Issue actions