GeezerVison

The World Wide Web, restored to 800 pixels of glory.

GeezerVison is showing github.com — gh-103186: Suppress RuntimeWarning about unclosed async iterator in test_sys_settrace by serhiy-storchaka · Pull Request #109075 · python/cpython

Conversation

serhiy-storchaka commented Sep 7, 2023 •

edited by bedevere-bot

Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link

Copy Markdown

Member

$ ./python -Wa -m test test_sys_settrace -m test_jump_out_of_async_for_block_forwards -m test_jump_out_of_async_for_block_backwards
...
/home/serhiy/py/cpython/Lib/test/support/__init__.py:758: RuntimeWarning: coroutine method 'aclose' of 'asynciter' was never awaited
  gc.collect()
RuntimeWarning: Enable tracemalloc to get the object allocation traceback
/home/serhiy/py/cpython/Lib/test/support/__init__.py:758: RuntimeWarning: coroutine method 'aclose' of 'asynciter' was never awaited
  gc.collect()
RuntimeWarning: Enable tracemalloc to get the object allocation traceback

Issue: Regression tests pass but return unnecessary output (errors and warnings) #103186

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions


          pythongh-103186: Suppress RuntimeWarning about unclosed async iterato…

d2b4866

…r in test_sys_settrace

serhiy-storchaka added tests

Tests in the Lib/test dir

skip news labels

Sep 7, 2023

bedevere-bot added the awaiting core review label

Sep 7, 2023

bedevere-bot mentioned this pull request

Sep 7, 2023

Regression tests pass but return unnecessary output (errors and warnings) #103186

Closed

serhiy-storchaka added needs backport to 3.11

only security fixes

needs backport to 3.12 only security fixes labels

Sep 7, 2023

serhiy-storchaka merged commit d485551 into python:main

Sep 7, 2023

miss-islington commented Sep 7, 2023

Copy link

Copy Markdown

Contributor

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot removed the awaiting core review label

Sep 7, 2023

serhiy-storchaka deleted the test_sys_settrace-warning-aclose branch

September 7, 2023 13:34

miss-islington commented Sep 7, 2023

Copy link

Copy Markdown

Contributor

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker d485551c9d1792ff3539eef1d6374bd4c01dcd5d 3.12

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

miss-islington assigned serhiy-storchaka

Sep 7, 2023

miss-islington commented Sep 7, 2023

Copy link

Copy Markdown

Contributor

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker d485551c9d1792ff3539eef1d6374bd4c01dcd5d 3.11

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request

Sep 7, 2023


          [3.11] pythongh-103186: Suppress RuntimeWarning about unclosed async …

6009a04

…iterator in test_sys_settrace (pythonGH-109075).

(cherry picked from commit d485551)

Co-authored-by: Serhiy Storchaka <[email protected]>

bedevere-bot commented Sep 7, 2023

Copy link

Copy Markdown

GH-109086 is a backport of this pull request to the 3.11 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot removed the needs backport to 3.11 only security fixes label

Sep 7, 2023

bedevere-bot commented Sep 7, 2023

Copy link

Copy Markdown

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot s390x SLES 3.x has failed when building commit d485551.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/540/builds/6442) and take a look at the build logs.
Check if the failure is related to this commit (d485551) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/540/builds/6442

Summary of the results of the build (if available):

Click to see traceback logs

remote: Enumerating objects: 66, done.        
remote: Counting objects:   1% (1/66)        
remote: Counting objects:   3% (2/66)        
remote: Counting objects:   4% (3/66)        
remote: Counting objects:   6% (4/66)        
remote: Counting objects:   7% (5/66)        
remote: Counting objects:   9% (6/66)        
remote: Counting objects:  10% (7/66)        
remote: Counting objects:  12% (8/66)        
remote: Counting objects:  13% (9/66)        
remote: Counting objects:  15% (10/66)        
remote: Counting objects:  16% (11/66)        
remote: Counting objects:  18% (12/66)        
remote: Counting objects:  19% (13/66)        
remote: Counting objects:  21% (14/66)        
remote: Counting objects:  22% (15/66)        
remote: Counting objects:  24% (16/66)        
remote: Counting objects:  25% (17/66)        
remote: Counting objects:  27% (18/66)        
remote: Counting objects:  28% (19/66)        
remote: Counting objects:  30% (20/66)        
remote: Counting objects:  31% (21/66)        
remote: Counting objects:  33% (22/66)        
remote: Counting objects:  34% (23/66)        
remote: Counting objects:  36% (24/66)        
remote: Counting objects:  37% (25/66)        
remote: Counting objects:  39% (26/66)        
remote: Counting objects:  40% (27/66)        
remote: Counting objects:  42% (28/66)        
remote: Counting objects:  43% (29/66)        
remote: Counting objects:  45% (30/66)        
remote: Counting objects:  46% (31/66)        
remote: Counting objects:  48% (32/66)        
remote: Counting objects:  50% (33/66)        
remote: Counting objects:  51% (34/66)        
remote: Counting objects:  53% (35/66)        
remote: Counting objects:  54% (36/66)        
remote: Counting objects:  56% (37/66)        
remote: Counting objects:  57% (38/66)        
remote: Counting objects:  59% (39/66)        
remote: Counting objects:  60% (40/66)        
remote: Counting objects:  62% (41/66)        
remote: Counting objects:  63% (42/66)        
remote: Counting objects:  65% (43/66)        
remote: Counting objects:  66% (44/66)        
remote: Counting objects:  68% (45/66)        
remote: Counting objects:  69% (46/66)        
remote: Counting objects:  71% (47/66)        
remote: Counting objects:  72% (48/66)        
remote: Counting objects:  74% (49/66)        
remote: Counting objects:  75% (50/66)        
remote: Counting objects:  77% (51/66)        
remote: Counting objects:  78% (52/66)        
remote: Counting objects:  80% (53/66)        
remote: Counting objects:  81% (54/66)        
remote: Counting objects:  83% (55/66)        
remote: Counting objects:  84% (56/66)        
remote: Counting objects:  86% (57/66)        
remote: Counting objects:  87% (58/66)        
remote: Counting objects:  89% (59/66)        
remote: Counting objects:  90% (60/66)        
remote: Counting objects:  92% (61/66)        
remote: Counting objects:  93% (62/66)        
remote: Counting objects:  95% (63/66)        
remote: Counting objects:  96% (64/66)        
remote: Counting objects:  98% (65/66)        
remote: Counting objects: 100% (66/66)        
remote: Counting objects: 100% (66/66), done.        
remote: Compressing objects:   3% (1/29)        
remote: Compressing objects:   6% (2/29)        
remote: Compressing objects:  10% (3/29)        
remote: Compressing objects:  13% (4/29)        
remote: Compressing objects:  17% (5/29)        
remote: Compressing objects:  20% (6/29)        
remote: Compressing objects:  24% (7/29)        
remote: Compressing objects:  27% (8/29)        
remote: Compressing objects:  31% (9/29)        
remote: Compressing objects:  34% (10/29)        
remote: Compressing objects:  37% (11/29)        
remote: Compressing objects:  41% (12/29)        
remote: Compressing objects:  44% (13/29)        
remote: Compressing objects:  48% (14/29)        
remote: Compressing objects:  51% (15/29)        
remote: Compressing objects:  55% (16/29)        
remote: Compressing objects:  58% (17/29)        
remote: Compressing objects:  62% (18/29)        
remote: Compressing objects:  65% (19/29)        
remote: Compressing objects:  68% (20/29)        
remote: Compressing objects:  72% (21/29)        
remote: Compressing objects:  75% (22/29)        
remote: Compressing objects:  79% (23/29)        
remote: Compressing objects:  82% (24/29)        
remote: Compressing objects:  86% (25/29)        
remote: Compressing objects:  89% (26/29)        
remote: Compressing objects:  93% (27/29)        
remote: Compressing objects:  96% (28/29)        
remote: Compressing objects: 100% (29/29)        
remote: Compressing objects: 100% (29/29), done.        
remote: Total 36 (delta 33), reused 8 (delta 7), pack-reused 0        
From https://github.com/python/cpython
 * branch                  main       -> FETCH_HEAD
Note: switching to 'd485551c9d1792ff3539eef1d6374bd4c01dcd5d'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by switching back to a branch.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -c with the switch command. Example:

  git switch -c <new-branch-name>

Or undo this operation with:

  git switch -

Turn off this advice by setting config variable advice.detachedHead to false

HEAD is now at d485551c9d gh-103186: Suppress RuntimeWarning about unclosed async iterator in test_sys_settrace (GH-109075)
Switched to and reset branch 'main'

make: *** [Makefile:2030: buildbottest] Error 3

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

serhiy-storchaka added a commit that referenced this pull request

Sep 7, 2023


          [3.11] gh-103186: Suppress RuntimeWarning about unclosed async iterat…

49cc2e7

…or in test_sys_settrace (GH-109075) (GH-109086)

(cherry picked from commit d485551)

serhiy-storchaka added needs backport to 3.12 only security fixes and removed needs backport to 3.12 only security fixes labels

Sep 8, 2023

miss-islington commented Sep 8, 2023

Copy link

Copy Markdown

Contributor

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request

Sep 8, 2023


          pythongh-103186: Suppress RuntimeWarning about unclosed async iterato…

400e2d5

…r in test_sys_settrace (pythonGH-109075)

(cherry picked from commit d485551)

Co-authored-by: Serhiy Storchaka <[email protected]>

bedevere-bot commented Sep 8, 2023

Copy link

Copy Markdown

GH-109138 is a backport of this pull request to the 3.12 branch.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

bedevere-bot removed the needs backport to 3.12 only security fixes label

Sep 8, 2023

serhiy-storchaka removed their assignment

Sep 8, 2023

Yhg1s pushed a commit that referenced this pull request

Sep 8, 2023


          [3.12] gh-103186: Suppress RuntimeWarning about unclosed async iterat…

a1ba0e5

…or in test_sys_settrace (GH-109075) (#109138)

gh-103186: Suppress RuntimeWarning about unclosed async iterator in test_sys_settrace (GH-109075)
(cherry picked from commit d485551)

Co-authored-by: Serhiy Storchaka <[email protected]>

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news tests

Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.

GeezerVison

Conversation

serhiy-storchaka commented Sep 7, 2023 • edited by bedevere-bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

miss-islington commented Sep 7, 2023

Uh oh!

miss-islington commented Sep 7, 2023

Uh oh!

miss-islington commented Sep 7, 2023

Uh oh!

bedevere-bot commented Sep 7, 2023

Uh oh!

bedevere-bot commented Sep 7, 2023

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Uh oh!

miss-islington commented Sep 8, 2023

Uh oh!

bedevere-bot commented Sep 8, 2023

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

serhiy-storchaka commented Sep 7, 2023 •

edited by bedevere-bot

Loading

Uh oh!

There was an error while loading. Please reload this page.