GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |||||||||
GeezerVison is showing github.com — gh-109151: Enable readline in the sqlite3 CLI by serhiy-storchaka · Pull Request #109152 · python/cpython Conversation
|
|
Thanks, Serhiy, this is very nice! Ideally, we should have this for 3.12. What do you think? I'm not sure it can be considered a defect/bug. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
It is clearly not a bug fix. But it is so much must have feature, that it should go in 3.12.1. Let wait on the release of 3.12.0. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
This is a new feature, IMO it's too late for Python 3.12. I dislike when Python behavior changes in 3.x.y bug releases, sorry. If you want readline in Python 3.12, you can write your CLI code: #import readline import sqlite3.__main__ import sys sqlite3.__main__.main(sys.argv[1:]) |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just some remarks on the NEWS entry.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
…kzkQu.rst Co-authored-by: Victor Stinner <[email protected]>
|
I forgot or didn't know that sqlite3 has a command-line interface. I created issue #109435 to document all stdlib modules which provides a command-line interface (CLI). |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
The sqlite3 CLI is new in 3.12. This is why I think it is a good idea to backport this change. I always use utilites that read from the stdin with an external wrapper ( |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Aha, you can negociate with @Yhg1s. First land it in the main branch :-) |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
(cherry picked from commit 254e30c) Co-authored-by: Serhiy Storchaka <[email protected]>
|
GH-110352 is a backport of this pull request to the 3.12 branch. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Thanks, Serhiy! |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
…ythonGH-109152) (python#110352)" This reverts commit bc1fe35.
…ythonGH-109152) (python#110352)" This reverts commit bc1fe35.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.