GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-108455: peg_generator: enable mypy's `--warn-unreachable` setting and `redundant-expr` error code by AlexWaygood · Pull Request #109160 · python/cpython

Conversation

@AlexWaygood

@AlexWaygood AlexWaygood commented Sep 8, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Closes #108455

The changes to the .py files are all due to branches that mypy flagged as being unreachable.

  • Issue: Run mypy on Tools/peg_generator #108455

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@AlexWaygood
peg_generator: enable mypy's --warn-unreachable setting and `redund…
95705d5 
…ant-expr` error code
@AlexWaygood AlexWaygood added the skip news label Sep 8, 2023
@AlexWaygood
AlexWaygood requested a review from sobolevn September 8, 2023 19:05
@AlexWaygood
AlexWaygood requested review from lysnikolaou and pablogsal as code owners September 8, 2023 19:05
@bedevere-bot bedevere-bot added the awaiting core review label Sep 8, 2023
@bedevere-bot bedevere-bot mentioned this pull request Sep 8, 2023
Run mypy on Tools/peg_generator #108455
Closed
pablogsal
pablogsal approved these changes Sep 8, 2023
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting core review labels Sep 8, 2023
@pablogsal
pablogsal merged commit 697c9dc into python:main Sep 8, 2023
@bedevere-bot bedevere-bot removed the awaiting merge label Sep 8, 2023
@pablogsal

pablogsal commented Sep 8, 2023

Copy link
Copy Markdown
Member

Thanks a lot @AlexWaygood !
AlexWaygood reacted with heart emoji
All reactions
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@AlexWaygood
AlexWaygood deleted the pegen-reachability branch September 8, 2023 21:18
@AlexWaygood

AlexWaygood commented Sep 8, 2023

Copy link
Copy Markdown
Member Author

You're very welcome @pablogsal, thanks for the reviews!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pablogsal pablogsal pablogsal approved these changes
@sobolevn sobolevn Awaiting requested review from sobolevn
@lysnikolaou lysnikolaou Awaiting requested review from lysnikolaou lysnikolaou is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Run mypy on Tools/peg_generator

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@AlexWaygood @pablogsal @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.