GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-109118: Disallow nested scopes within PEP 695 scopes within classes by JelleZijlstra · Pull Request #109196 · python/cpython

Conversation

@JelleZijlstra

@JelleZijlstra JelleZijlstra commented Sep 9, 2023 •
edited by bedevere-bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Fixes #109118. Fixes #109194.

See #109118 (comment).

  • Issue: Annotation scopes containing nested scopes #109118

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
JelleZijlstra added 4 commits September 9, 2023 10:37
@JelleZijlstra
New test
0e99835
@JelleZijlstra
more and more isolated tests
cb30ae1
@JelleZijlstra
Similar test with aliases, which already passes
725ca36
@JelleZijlstra
pythongh-109118: Disallow nested scopes within PEP 695 scopes within …
d7be560 
…classes

Fixes python#109118. Fixes python#109194.
@JelleZijlstra JelleZijlstra added the needs backport to 3.12 only security fixes label Sep 9, 2023
@JelleZijlstra
JelleZijlstra requested a review from carljm September 9, 2023 19:51
@bedevere-bot bedevere-bot added the awaiting core review label Sep 9, 2023
@bedevere-bot bedevere-bot mentioned this pull request Sep 9, 2023
Annotation scopes containing nested scopes #109118
Closed
carljm
carljm approved these changes Sep 11, 2023
View reviewed changes
Comment thread Lib/test/test_type_params.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@JelleZijlstra @carljm
Update Lib/test/test_type_params.py
ea69d36 
Co-authored-by: Carl Meyer <[email protected]>
@JelleZijlstra
JelleZijlstra merged commit b88d9e7 into python:main Sep 12, 2023
@miss-islington

miss-islington commented Sep 12, 2023

Copy link
Copy Markdown
Contributor

Thanks @JelleZijlstra for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@JelleZijlstra
JelleZijlstra deleted the fixclassgenexp branch September 12, 2023 00:11
@bedevere-app bedevere-app Bot removed the awaiting core review label Sep 12, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 12, 2023
@JelleZijlstra @carljm @miss-islington
pythongh-109118: Disallow nested scopes within PEP 695 scopes within …
0dc03f4 
…classes (pythonGH-109196)

Fixes pythonGH-109118. Fixes pythonGH-109194.

(cherry picked from commit b88d9e7)

Co-authored-by: Jelle Zijlstra <[email protected]>
Co-authored-by: Carl Meyer <[email protected]>
@bedevere-app

bedevere-app Bot commented Sep 12, 2023

Copy link
Copy Markdown

GH-109297 is a backport of this pull request to the 3.12 branch.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the needs backport to 3.12 only security fixes label Sep 12, 2023
Yhg1s pushed a commit that referenced this pull request Sep 12, 2023
@miss-islington @JelleZijlstra @carljm
[3.12] gh-109118: Disallow nested scopes within PEP 695 scopes within…
8208657 
… classes (GH-109196) (#109297)

gh-109118: Disallow nested scopes within PEP 695 scopes within classes (GH-109196)

Fixes GH-109118. Fixes GH-109194.

(cherry picked from commit b88d9e7)

Co-authored-by: Jelle Zijlstra <[email protected]>
Co-authored-by: Carl Meyer <[email protected]>
vstinner pushed a commit to vstinner/cpython that referenced this pull request Sep 13, 2023
@JelleZijlstra @carljm @vstinner
pythongh-109118: Disallow nested scopes within PEP 695 scopes within …
cc1f90e 
…classes (python#109196)

Fixes python#109118. Fixes python#109194.

Co-authored-by: Carl Meyer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@carljm carljm carljm approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bug with comprehension inlining + type aliases Annotation scopes containing nested scopes

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@JelleZijlstra @miss-islington @carljm @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.